[GitHub] [iceberg] jackye1995 commented on pull request #6786: Spark-3.3: Support unregister table procedure

["jackye1995 (via GitHub)" <gi...@apache.org>]

jackye1995 commented on PR #6786:
URL: https://github.com/apache/iceberg/pull/6786#issuecomment-1424727896

   I would +1 on having this at catalog API level, and +1 on making this a catalog-specific implementation for drop table so user can just run `DROP TABLE` as usual, instead of having an `unregisterTable` API, I don't know how we can define `unregister` for it to make sense from catalog perspective...
   
   Why can't this just be:
   
   ```
   public boolean dropTable(TableIdentifier identifier, boolean purge) {
     try {
       // original logic
     } catch (RuntimeException e) {
       // do catalog specific removal
     }
   }
   ```
   
   Especially I think for Nessie this is just a client call, so it makes it even easier because you can just do this on server side.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org