You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2026/10/15 20:23:09 UTC

[I] Stop committing the framework's own .claude/settings.json; ship it as a template [magpie]

potiuk opened a new issue, #1639:
URL: https://github.com/apache/magpie/issues/1639

   ### What should happen
   
   The Magpie repository stops committing `.claude/settings.json`. Its contents become a template, plus a documented step that contributors (and the secure-setup install) follow to put it in place locally.
   
   ### Why
   
   The file in this repository is the maintainers' working configuration, not something a contributor's agent should silently inherit on clone. It mixes two things:
   
   - the sandbox and permission baseline (`sandbox.*`, `permissions.*`);
   - the self-adoption wiring (`extraKnownMarketplaces`, `enabledPlugins`).
   
   Because it is committed, every change to it is a repository change. Contributors also get the maintainers' choices whether or not they want them, and a cloned checkout can never differ from the baseline without a dirty tree.
   
   ### Which layer
   
   The repository root `.claude/settings.json`, plus every surface that references it:
   
   - `.github/workflows/sandbox-lint.yml` and `tools/sandbox-lint/expected.json` (the lint baseline);
   - `.asf.yaml` (the required `sandbox-lint` check);
   - `.pre-commit-config.yaml` (the exclusion it gets);
   - `plugins/magpie-setup/skills/setup/setup_preflight/isolated.py` (it is listed as a dogfooded file);
   - `docs/security/threat-model.md` (mitigation M.14 cites its `allowedDomains`);
   - `docs/setup/secure-agent-setup.md`, `docs/setup/secure-agent-internals.md`, `docs/spec-driven-development.md` and `plugins/magpie-utilities/skills/write-skill/security-checklist.md` (they link it as the block to copy).
   
   ### Boundary conditions
   
   - Ship the template at a tracked path outside `.claude/` (for example `tools/agent-isolation/claude-settings.template.json`), and gitignore `.claude/settings.json` in this repository.
   - Retarget `sandbox-lint`, the preflight fingerprint and the doc links at the template, so the baseline stays linted and required in CI.
   - Add the contributor step to the contributor docs and to `setup-isolated-setup-install`: copy or merge the template into `.claude/settings.json` (or `settings.local.json`), with `isolated-setup-verify` reporting when it is missing.
   - An adopter's `adopt` still writes its own committed `.claude/settings.json` floor. This issue is about the Magpie repository only.
   
   ### Out of scope
   
   Changing the contents of the baseline.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Stop committing the framework's own .claude/settings.json; ship it as a template [magpie]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed issue #1639: Stop committing the framework's own .claude/settings.json; ship it as a template
URL: https://github.com/apache/magpie/issues/1639


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org