You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shai Erera (JIRA)" <ji...@apache.org> on 2013/03/14 22:02:13 UTC
[jira] [Commented] (LUCENE-4830) Sorter API: use an abstract doc
map instead of an array
[ https://issues.apache.org/jira/browse/LUCENE-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13602732#comment-13602732 ]
Shai Erera commented on LUCENE-4830:
------------------------------------
Looks good! I spotted missing @Override in REVERSE_SORTER DocMap and I think that we should make the DocMap impl final? Maybe it will encourage JIT ...
+1!
> Sorter API: use an abstract doc map instead of an array
> -------------------------------------------------------
>
> Key: LUCENE-4830
> URL: https://issues.apache.org/jira/browse/LUCENE-4830
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Trivial
> Fix For: 4.3
>
> Attachments: LUCENE-4830.patch
>
>
> The sorter API uses arrays to store the old->new and new->old doc IDs mappings. It should rather be an abstract class given that in some cases an array is not required at all (reverse mapping for example).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org