You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "cmccabe (via GitHub)" <gi...@apache.org> on 2023/04/12 17:11:36 UTC

[GitHub] [kafka] cmccabe commented on pull request #13521: MINOR: Add tests verifying leadership during and after reassignments in KRaft mode

cmccabe commented on PR #13521:
URL: https://github.com/apache/kafka/pull/13521#issuecomment-1505631320

   Thanks for tackling this!
   
   Question about the first test:
   
   > First, it adds a test that makes sure we handle what happens when a reassignment completes and none of the new replicas can be made leader. Its important we dont keep an old replica as leader.
   
   The reassignment won't complete until the new nodes are in the ISR, right? So I'm curious how this could happen in practice. I must be missing something...
   
   Second test looks 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org