You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "warrenzhu25 (via GitHub)" <gi...@apache.org> on 2023/09/28 18:58:40 UTC
[GitHub] [spark] warrenzhu25 opened a new pull request, #43173: [SPARK-45372][CORE] Handle ClassNotFoundException when load extension
warrenzhu25 opened a new pull request, #43173:
URL: https://github.com/apache/spark/pull/43173
### What changes were proposed in this pull request?
Skip extension load when `ClassNotFoundException` encountered and log error
### Why are the changes needed?
When load extension with ClassNotFoundException, SparkContext failed to initialize. Better behavior is skip this extension and log error without failing SparkContext initialization.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Added UT in `UtilsSuite.scala`
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45372][CORE] Handle ClassNotFoundException when load extension [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #43173: [SPARK-45372][CORE] Handle ClassNotFoundException when load extension
URL: https://github.com/apache/spark/pull/43173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45372][CORE] Handle ClassNotFoundException when load extension [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43173:
URL: https://github.com/apache/spark/pull/43173#issuecomment-1880242312
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #43173: [SPARK-45372][CORE] Handle ClassNotFoundException when load extension
Posted by "mridulm (via GitHub)" <gi...@apache.org>.
mridulm commented on PR #43173:
URL: https://github.com/apache/spark/pull/43173#issuecomment-1740269540
Agree with @JoshRosen's comment - for example, these could be sql extensions or shuffle components - it is preferable to fail the application than to ignore the class loading error: users can fix the failure by making appropriate config or dependency changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org