[GitHub] [cxf] jimma commented on pull request #855: [CXF-8371]:initial/experimental jakarta ee9 support with eclipse transformer

[GitBox <gi...@apache.org>]

jimma commented on pull request #855:
URL: https://github.com/apache/cxf/pull/855#issuecomment-938404858


   > Thanks for doing this work @jimma , I think if we just scope it to rewriting packages in binary, it should work. There are 3 concerns which I would like to hear your opinion:
   
   > * Rewriting OSGi manifests may require a lot of efforts since we may need to adjust the version or version range. The way we may tackle it is to inspect all manifests and prepare the GAV map (the keys) by script. It should be more or less clear what the replacement patterns should be.
   
   I actually didn't think of OSGI manifest.  Can you please point me the code how does CXF generate OSGI manifest now? Or some quick transformation example of OSGI for me to understand what we need to do ?
   
   > * Rewriting POM files needs more than just CXF artifacts, I think we need to bump all `jakarta` dependencies to correct versions and/or do eliminate of `javax` artifacts in favor of `jakarka` artifacts if we did not bring the replacement yet.
   
   Yes. This is the major part work of transformation. I created the https://github.com/jimma/cxf/blob/ee9/ee9/src/main/resources/gav.map to provide the javax artifact to jakarta artifact replacement information. These javax artifacts will be all replaced with jakarta artifacts if these are defined in  this mapping rule file.
   
   > * Last but not least, it would be great to make at least some sanity checks for the artifact produced. I am thinking about Jakarta TCKs (the subset of), we would need to run it anyway at some point, so earlier we have it, better.
   > 
   
   That's exactly what we should do for the next step. We can start with some jakarta ee9 smoke tests first and later run against with Jakarta jaxws standalone TCK. 
   
   > Do you think those are valid concerns? What are your thoughts? Thank you!
   
   Thanks for you valuable review and input for this topic. Another thing I am not sure is : to transform cxf artifacts, should we have some subset of cxf artifacts to transform first instead of transforming all the things ? Should we draft some work plan to get this done step by step ? 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org