You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by vinodkc <gi...@git.apache.org> on 2017/08/01 06:22:19 UTC
[GitHub] storm pull request #2251: [STORM-2613] Tuples that aren't sampled shouldn't ...
GitHub user vinodkc opened a pull request:
https://github.com/apache/storm/pull/2251
[STORM-2613] Tuples that aren't sampled shouldn't be considered for latency calculation
Set delta to -1 , so that time delay for tuples that aren't sampled will not be added in BoltExecutorStats.
This is a followup PR of https://github.com/apache/storm/pull/2185 to fix 1.x version
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vinodkc/storm-1 br_fix_stat_issue_in_1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2251.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2251
----
commit fa9262d2a1d4cbeb20b25e0f36c084f20308efa1
Author: vinodkc <vi...@gmail.com>
Date: 2017-08-01T06:17:50Z
Tuples that aren't sampled shouldn't be considered for latency calculion
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2251: [STORM-2677] consider all sampled tuples which took great...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2251
@vinodkc Thanks for changing the PR title. Could you change commit title as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2251: [STORM-2677] consider all sampled tuples which took great...
Posted by vinodkc <gi...@git.apache.org>.
Github user vinodkc commented on the issue:
https://github.com/apache/storm/pull/2251
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2251: [STORM-2613] Tuples that aren't sampled shouldn't be cons...
Posted by vinodkc <gi...@git.apache.org>.
Github user vinodkc commented on the issue:
https://github.com/apache/storm/pull/2251
retest this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2251: [STORM-2613] Tuples that aren't sampled shouldn't be cons...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2251
Btw it is clearly a bug, but in opposite to STORM-2613, because both nil and 0 are logically false. So it doesn't include tuples which are not sampled, but it also doesn't include tuples which are done in 0 ms. Less harmful but still affects the overall latency.
@vinodkc
I guess we need to file different issue for this, since the bug is affecting differently. Could you please follow up? Thanks in advance!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2251: [STORM-2677] consider all sampled tuples which took great...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2251
@vinodkc I merged this with some modification (commit title) but auto-close didn't work because it is pointing to non master branch. Could you close this? Thanks again for contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2251: [STORM-2613] Tuples that aren't sampled shouldn't be cons...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2251
@vinodkc
OK. Please squash commits into one with changing commit title corresponding to STORM-2677. Please also change PR title as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2251: [STORM-2613] Tuples that aren't sampled shouldn't be cons...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2251
The failure looks unrelated.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2251: [STORM-2613] Tuples that aren't sampled shouldn't be cons...
Posted by vinodkc <gi...@git.apache.org>.
Github user vinodkc commented on the issue:
https://github.com/apache/storm/pull/2251
@HeartSaVioR
Sure, filed a new issue STORM-2677.
Can you please change the status of STORM-2613.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2251: [STORM-2677] consider all sampled tuples which took great...
Posted by vinodkc <gi...@git.apache.org>.
Github user vinodkc commented on the issue:
https://github.com/apache/storm/pull/2251
@HeartSaVioR , Thanks for the review comments.
I've changed commit title
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2251: [STORM-2677] consider all sampled tuples which too...
Posted by vinodkc <gi...@git.apache.org>.
Github user vinodkc closed the pull request at:
https://github.com/apache/storm/pull/2251
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---