You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/25 13:45:51 UTC

[GitHub] [spark] Yikun commented on a change in pull request #31647: [SPARK-34539] [BUILD] [INFRA] Remove stand-alone version Zinc server.

Yikun commented on a change in pull request #31647:
URL: https://github.com/apache/spark/pull/31647#discussion_r582843283



##########
File path: pom.xml
##########
@@ -2534,7 +2534,6 @@
             <checkMultipleScalaVersions>true</checkMultipleScalaVersions>
             <failOnMultipleScalaVersions>true</failOnMultipleScalaVersions>
             <recompileMode>incremental</recompileMode>
-            <useZincServer>true</useZincServer>

Review comment:
       The [`useZincServer` has been removed](https://github.com/davidB/scala-maven-plugin/pull/321/files#diff-7d0815d86a5ea5598e1ee37c18a5592e90820c22ea61202bd83ae0dba066225dL83-L84) and the [incremental feature is enable by default](https://github.com/davidB/scala-maven-plugin/commit/0f01f2fe37aaadbefb02fb713d469dbd10acf8b1), in scala-maven-plugin 4.X. and the arg [recompileMode](https://github.com/davidB/scala-maven-plugin/blob/d7d19a2e98e7661d30fadb726fb0e91177eee5b6/src/main/java/scala_maven/ScalaCompilerSupport.java#L45-L50) is used to enable or disable the increamtal compiler.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org