You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/11/01 22:24:55 UTC
[kudu-CR] mini kdc: search for lsof in /usr/sbin as well
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4906
to review the following change.
Change subject: mini_kdc: search for lsof in /usr/sbin as well
......................................................................
mini_kdc: search for lsof in /usr/sbin as well
In RHEL 6, lsof is in /usr/sbin/ instead of /sbin, and this directory
isn't guaranteed to be in $PATH. This adds it to the search path.
Change-Id: I9a23a17fc2292edb899ae934c274951cf9c55b9f
---
M src/kudu/security/mini_kdc.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/4906/1
--
To view, visit http://gerrit.cloudera.org:8080/4906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a23a17fc2292edb899ae934c274951cf9c55b9f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] mini kdc: search for lsof in /usr/sbin as well
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: mini_kdc: search for lsof in /usr/sbin as well
......................................................................
mini_kdc: search for lsof in /usr/sbin as well
In RHEL 6, lsof is in /usr/sbin/ instead of /sbin, and this directory
isn't guaranteed to be in $PATH. This adds it to the search path.
Change-Id: I9a23a17fc2292edb899ae934c274951cf9c55b9f
Reviewed-on: http://gerrit.cloudera.org:8080/4906
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/security/mini_kdc.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a23a17fc2292edb899ae934c274951cf9c55b9f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] mini kdc: search for lsof in /usr/sbin as well
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: mini_kdc: search for lsof in /usr/sbin as well
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a23a17fc2292edb899ae934c274951cf9c55b9f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No