[GitHub] spark pull request #14251: [SPARK-16602][SQL] `Nvl` function should support ...

[dongjoon-hyun <gi...@git.apache.org>]

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14251#discussion_r71247244
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ---
    @@ -2965,4 +2965,19 @@ class SQLQuerySuite extends QueryTest with SharedSQLContext {
           }
         }
       }
    +
    +  test("SPARK-16602 Nvl/Coalesce") {
    +    // NVL uses the first parameter data type.
    +    checkAnswer(sql("select nvl('0', 1)"), Row("0"))
    +    checkAnswer(sql("select nvl(0, '1')"), Row(0))
    +    checkAnswer(sql("select nvl(null, '1')"), Row("1"))
    +    checkAnswer(sql("select nvl(null, 1.1)"), Row(1.1))
    +
    +    // Coalesce do TypeCoercion to make them homogeneous.
    +    checkAnswer(sql("select coalesce('0', 1)"), Row("0"))
    +    checkAnswer(sql("select coalesce(0, '1')"), Row("0"))
    +    checkAnswer(sql("select coalesce(null, '1')"), Row("1"))
    +    checkAnswer(sql("select coalesce(null, 1.1)"), Row(1.1))
    +    checkAnswer(sql("select coalesce(null, 1.1, '1')"), Row("1.1"))
    --- End diff --
    
    @rxin . Here, I added the comparison tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org