You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/01/14 15:01:38 UTC
[GitHub] [cassandra] ifesdjeen opened a new pull request #423: Cassandra
15497 in jvm bootstrap
ifesdjeen opened a new pull request #423: Cassandra 15497 in jvm bootstrap
URL: https://github.com/apache/cassandra/pull/423
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] ifesdjeen commented on a change in pull request #423:
Cassandra 15497 in jvm bootstrap
Posted by GitBox <gi...@apache.org>.
ifesdjeen commented on a change in pull request #423: Cassandra 15497 in jvm bootstrap
URL: https://github.com/apache/cassandra/pull/423#discussion_r371271682
##########
File path: test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java
##########
@@ -473,9 +519,11 @@ void startup()
// and then start any instances with it disabled in parallel.
List<I> startSequentially = new ArrayList<>();
List<I> startParallel = new ArrayList<>();
- for (I instance : instances)
+ for (int i = 0; i < instances.size(); i++)
{
- if ((boolean) instance.config().get("auto_bootstrap"))
+ I instance = instances.get(i);
+
+ if (i == 0 || (boolean) instance.config().get("auto_bootstrap"))
Review comment:
probably deserves a comment but the logic here was "start seed sequentially"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org