You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/09/21 13:21:44 UTC
Review Request 38551: [1/2]CMake: Add version info for APR we need to
build Windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38551/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3383
https://issues.apache.org/jira/browse/MESOS-3383
Repository: mesos
Description
-------
[1/2]CMake: Add version info for APR we need to build Windows.
Diffs
-----
3rdparty/cmake/Versions.cmake PRE-CREATION
Diff: https://reviews.apache.org/r/38551/diff/
Testing
-------
Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
* OS X 10.10
* Windows 10
* Ubuntu 14.04.2
Thanks,
Alex Clemmer
Re: Review Request 38551: [1/2]CMake: Add version info for APR we
need to build Windows.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38551/#review99801
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Sept. 21, 2015, 4:21 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38551/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2015, 4:21 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3383
> https://issues.apache.org/jira/browse/MESOS-3383
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [1/2]CMake: Add version info for APR we need to build Windows.
>
>
> Diffs
> -----
>
> 3rdparty/cmake/Versions.cmake PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38551/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38551: [1/2]CMake: Add version info for APR we
need to build Windows.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38551/#review100610
-----------------------------------------------------------
LGTM.
- Artem Harutyunyan
On Sept. 21, 2015, 11:30 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38551/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2015, 11:30 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3383
> https://issues.apache.org/jira/browse/MESOS-3383
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [1/2]CMake: Add version info for APR we need to build Windows.
>
>
> Diffs
> -----
>
> 3rdparty/cmake/Versions.cmake PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38551/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38551: [1/2]CMake: Add version info for APR we
need to build Windows.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38551/#review100739
-----------------------------------------------------------
Ship it!
- Joris Van Remoortere
On Sept. 21, 2015, 6:30 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38551/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2015, 6:30 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3383
> https://issues.apache.org/jira/browse/MESOS-3383
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [1/2]CMake: Add version info for APR we need to build Windows.
>
>
> Diffs
> -----
>
> 3rdparty/cmake/Versions.cmake PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38551/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38551: [1/2]CMake: Add version info for APR we
need to build Windows.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38551/
-----------------------------------------------------------
(Updated Sept. 26, 2015, 10:05 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3383
https://issues.apache.org/jira/browse/MESOS-3383
Repository: mesos
Description
-------
[1/2]CMake: Add version info for APR we need to build Windows.
Diffs (updated)
-----
3rdparty/cmake/Versions.cmake PRE-CREATION
Diff: https://reviews.apache.org/r/38551/diff/
Testing
-------
Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
* OS X 10.10
* Windows 10
* Ubuntu 14.04.2
Thanks,
Alex Clemmer
Re: Review Request 38551: [1/2]CMake: Add version info for APR we
need to build Windows.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38551/
-----------------------------------------------------------
(Updated Sept. 21, 2015, 6:30 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3383
https://issues.apache.org/jira/browse/MESOS-3383
Repository: mesos
Description
-------
[1/2]CMake: Add version info for APR we need to build Windows.
Diffs (updated)
-----
3rdparty/cmake/Versions.cmake PRE-CREATION
Diff: https://reviews.apache.org/r/38551/diff/
Testing
-------
Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
* OS X 10.10
* Windows 10
* Ubuntu 14.04.2
Thanks,
Alex Clemmer