[GitHub] [cassandra] ekaterinadimitrova2 commented on a change in pull request #980: CASSANDRA-16567 (3.0): Fix test ViewTest.testCompoundPartitionKey

[GitBox <gi...@apache.org>]

ekaterinadimitrova2 commented on a change in pull request #980:
URL: https://github.com/apache/cassandra/pull/980#discussion_r618842591



##########
File path: src/java/org/apache/cassandra/db/view/View.java
##########
@@ -206,15 +206,20 @@ public ReadQuery getReadQuery()
 
     public synchronized void build()
     {
-        if (this.builder != null)

Review comment:
       I am not sure I understand correctly why you remove this check?

##########
File path: src/java/org/apache/cassandra/db/view/ViewBuilder.java
##########
@@ -209,4 +206,16 @@ public boolean isGlobal()
     {
         return false;
     }
+
+    public void waitForCompletion()

Review comment:
       I think this method can be `protected` and not `public`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org