You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ws.apache.org by "Colm O hEigeartaigh (Created) (JIRA)" <ji...@apache.org> on 2012/03/06 13:28:57 UTC
[jira] [Created] (WSS-355) Reconcile SAMLCallback between the two
implementations
Reconcile SAMLCallback between the two implementations
------------------------------------------------------
Key: WSS-355
URL: https://issues.apache.org/jira/browse/WSS-355
Project: WSS4J
Issue Type: Sub-task
Reporter: Colm O hEigeartaigh
Assignee: Colm O hEigeartaigh
Fix For: 2.0
The SAMLCallback in SWSSF contains signing information, whereas it does not in WSS4J. SAMLParms and SAMLIssuer* will be removed in the DOM code as part of this work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Commented] (WSS-355) Reconcile SAMLCallback between the two
implementations
Posted by "Marc Giger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSS-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493094#comment-13493094 ]
Marc Giger commented on WSS-355:
--------------------------------
Hi Colm,
The StAX and DOM productive code uses the same SAMLCallback:
./ws-security-common/src/main/java/org/apache/ws/security/common/saml/SAMLCallback.java
For testing we have the following Callback's:
./ws-security-stax/src/test/java/org/apache/ws/security/stax/test/saml/AbstractSAMLCallbackHandler.java
./ws-security-stax/src/test/java/org/apache/ws/security/stax/test/saml/SAML2CallbackHandler.java
./ws-security-stax/src/test/java/org/apache/ws/security/stax/test/saml/SAML1CallbackHandler.java
./ws-security-dom/src/test/java/org/apache/ws/security/dom/common/AbstractSAMLCallbackHandler.java
./ws-security-dom/src/test/java/org/apache/ws/security/dom/common/SAML2CallbackHandler.java
./ws-security-dom/src/test/java/org/apache/ws/security/dom/common/SAMLElementCallbackHandler.java
./ws-security-dom/src/test/java/org/apache/ws/security/dom/common/SAML1CallbackHandler.java
The differences between these are the issuer things which is necessary because of the different testing setup for StAX.
I can refactor it so that both test implementations use the same Callbacks but the issuer stuff will still be needed for StAX testing.
Can/should I refactor it and enrich the common callbacks with the issuer stuff for testing the StAX impl.?
Marc
> Reconcile SAMLCallback between the two implementations
> ------------------------------------------------------
>
> Key: WSS-355
> URL: https://issues.apache.org/jira/browse/WSS-355
> Project: WSS4J
> Issue Type: Sub-task
> Reporter: Colm O hEigeartaigh
> Assignee: Colm O hEigeartaigh
> Fix For: 2.0
>
>
> The SAMLCallback in SWSSF contains signing information, whereas it does not in WSS4J. SAMLParms and SAMLIssuer* will be removed in the DOM code as part of this work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Resolved] (WSS-355) Reconcile SAMLCallback between the two
implementations
Posted by "Marc Giger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSS-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marc Giger resolved WSS-355.
----------------------------
Resolution: Fixed
Assignee: Marc Giger (was: Colm O hEigeartaigh)
resolved in 1408279.
> Reconcile SAMLCallback between the two implementations
> ------------------------------------------------------
>
> Key: WSS-355
> URL: https://issues.apache.org/jira/browse/WSS-355
> Project: WSS4J
> Issue Type: Sub-task
> Reporter: Colm O hEigeartaigh
> Assignee: Marc Giger
> Fix For: 2.0
>
>
> The SAMLCallback in SWSSF contains signing information, whereas it does not in WSS4J. SAMLParms and SAMLIssuer* will be removed in the DOM code as part of this work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Commented] (WSS-355) Reconcile SAMLCallback between the two
implementations
Posted by "Colm O hEigeartaigh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSS-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493866#comment-13493866 ]
Colm O hEigeartaigh commented on WSS-355:
-----------------------------------------
Hi Marc,
The original issue was that the WSS4J 1.6.x code did not use any signing functionality in SAMLCallback. If both sets of code are now consistent then this issue can be resolved.
I think it's ok to have separate Callbacks in the test code - I'll leave it up to you whether you want to refactor it or not.
Colm.
> Reconcile SAMLCallback between the two implementations
> ------------------------------------------------------
>
> Key: WSS-355
> URL: https://issues.apache.org/jira/browse/WSS-355
> Project: WSS4J
> Issue Type: Sub-task
> Reporter: Colm O hEigeartaigh
> Assignee: Colm O hEigeartaigh
> Fix For: 2.0
>
>
> The SAMLCallback in SWSSF contains signing information, whereas it does not in WSS4J. SAMLParms and SAMLIssuer* will be removed in the DOM code as part of this work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org