[GitHub] sgoldberg-sfdc opened a new pull request #408: CB-14192: (ios) - Xcode 10 Framework Target Fix - Convert Framework to build source rather than wrap static lib

[GitBox <gi...@apache.org>]

sgoldberg-sfdc opened a new pull request #408: CB-14192: (ios) - Xcode 10 Framework Target Fix - Convert Framework to build source rather than wrap static lib
URL: https://github.com/apache/cordova-ios/pull/408
 
 
   -  The new build system in Xcode 10 gets confused by the static library header files copied to $CONFIGURATION_BUILD_DIR/include
   -  By making the framework target build the source directly we eliminate this issue
   -  If both targets are built, the issue will still occur
   
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   iOS
   
   ### What does this PR do?
   Modifies the framework target to compile the source directly, rather than wrap the static library target. This avoids the issue where the static library header files are copied to the $CONFIGURATION_BUILD_DIR confusing the new build system (defaulted on in Xcode 10) resulting in duplicate definition errors. 
   
   ### What testing has been done on this change?
   Manually verified builds of both targets within xcode and via Carthage.
   
   ### Checklist
   - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [X] Added automated test coverage as appropriate for this change. (None required)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org