Re: [PR] ci: add RC promotion command [burr]

["andreahlert (via GitHub)" <gi...@apache.org>]

andreahlert commented on PR #749:
URL: https://github.com/apache/burr/pull/749#issuecomment-4602801814

   Thanks @Haricharanpanjwani! I pushed a couple of commits to get this green and to correct the release-side layout.
   
   **Formatting**
   - Ran `black` on `scripts/apache_release.py` and `tests/test_apache_release.py` (the `pre-commit` black hook was failing).
   
   **Release layout fix**
   The original flow copied the artifacts flat into the `dist/release` project root and `svn rm`'d every existing entry except `KEYS`. But our `dist/release/incubator/burr` publishes each release under a per-version subdirectory (`0.41.0/`, `0.42.0/`, …) and keeps prior releases alongside the shared `KEYS`. Run as-is, `promote` would have placed the artifacts in the wrong location and deleted the already-published `0.41.0` and `0.42.0` releases.
   
   Reworked `promote` to a single atomic server-side copy:
   
   ```
   svn cp <dev_rc_url> <release_root>/<version> -m "..."
   ```
   
   - additive: existing release directories and `KEYS` are untouched by construction
   - no local download of the release tree
   - refuses to run if the target version directory already exists
   - the RC is still checked out locally only to validate the expected artifacts and their `.asc` / `.sha512` companions before promotion
   
   This also let me drop the flat-copy/remove/commit helpers and the unused RC-suffix rename (the release artifact names never carry the RC number, it lives in the dev directory name). README and tests updated to match; net `-78` lines.
   
   One caveat: the SVN workflow is unit-tested with mocked `svn`, but I have not verified it end-to-end against live ASF dist.
   
   **Minor follow-up (non-blocking):** `_promotion_source_url` and the artifact patterns hardcode `-incubating`, so the `--dev-svn-root` / `--release-svn-root` overrides won't fully cover the post-graduation TLP paths yet. Fine while we're incubating; worth deriving the `-incubating` segment from context in a later change.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@burr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org