You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2025/08/04 09:24:36 UTC

[PR] add deprecated annotations to FunctionalInterfaces that are being removed in pekko 2.0.0 [pekko]

pjfanning opened a new pull request, #2004:
URL: https://github.com/apache/pekko/pull/2004

   * these are being removed in main branch - #2001 
   * so this is targeted only at 1.2.x branch to warn users


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] add deprecated annotations to FunctionalInterfaces that are being removed in pekko 2.0.0 [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #2004:
URL: https://github.com/apache/pekko/pull/2004#issuecomment-3150080298

   This is still broken. I will return to it later today.
   There may some additional issues but my main blocker is in actor-tests - some of the Java tests won't compile without warning despite the fact that I have `@Suppress` annotation on the classes.
   
   ```
   [warn] /home/runner/work/pekko/pekko/actor-tests/src/test/java/org/apache/pekko/actor/ActorCreationTest.java:25:29: org.apache.pekko.japi.Creator in org.apache.pekko.japi has been deprecated
   [warn] org.apache.pekko.japi.Creator
   [warn]                             ^
   [warn] /home/runner/work/pekko/pekko/actor-tests/src/test/java/org/apache/pekko/actor/JavaAPI.java:18:29: org.apache.pekko.japi.Creator in org.apache.pekko.japi has been deprecated
   [warn] org.apache.pekko.japi.Creator
   [warn]                             ^
   [warn] /home/runner/work/pekko/pekko/actor-tests/src/test/java/org/apache/pekko/actor/NonStaticCreator.java:16:29: org.apache.pekko.japi.Creator in org.apache.pekko.japi has been deprecated
   [warn] org.apache.pekko.japi.Creator
   [warn]                             ^
   [error] warnings found and -Werror specified
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] add deprecated annotations to FunctionalInterfaces that are being removed in pekko 2.0.0 [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #2004:
URL: https://github.com/apache/pekko/pull/2004#issuecomment-3150590588

   I have the compile problems fixed now. I had to make a few messy changes to some Java tests. I couldn't get the compiler to stop failing due to the import of a deprecated class even with SuppressWarnings. I worked around it by removing the import and fully referencing the class where it is referenced.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] add deprecated annotations to FunctionalInterfaces that are being removed in pekko 2.0.0 [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #2004:
URL: https://github.com/apache/pekko/pull/2004


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] add deprecated annotations to FunctionalInterfaces that are being removed in pekko 2.0.0 [pekko]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #2004:
URL: https://github.com/apache/pekko/pull/2004#issuecomment-3149941009

   > @pjfanning The `Option` in this class will be removed too, and migrate to Java's Optional.
   
   Nice pickup, I guess these `Optional` classes where there for earlier versions than Java 1.8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] add deprecated annotations to FunctionalInterfaces that are being removed in pekko 2.0.0 [pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #2004:
URL: https://github.com/apache/pekko/pull/2004#issuecomment-3149921053

   @pjfanning The `Option` in this class will be removed too, and migrate to Java's Optional.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org