You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@shindig.apache.org by "Bastian Hofmann (JIRA)" <ji...@apache.org> on 2010/07/21 09:47:51 UTC

[jira] Created: (SHINDIG-1391) Small improvements in Config class

Small improvements in Config class
----------------------------------

                 Key: SHINDIG-1391
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1391
             Project: Shindig
          Issue Type: Improvement
          Components: PHP
            Reporter: Bastian Hofmann


- Loading of config files is now done with an absolute path which is quicker in php
- better exception message if config key not found

Index: php/src/common/Config.php
===================================================================
35c35
<       include_once 'config/container.php';
---
>       include_once realpath(dirname(__FILE__) . "/../../config") . '/container.php';
37c37
<       $localConfigPath = realpath(dirname(__FILE__) . "/../../config/local.php");
---
>       $localConfigPath = realpath(dirname(__FILE__) . "/../../config") . '/local.php';
64c64
<       throw new ConfigException("Invalid Config Key");
---
>       throw new ConfigException("Invalid Config Key " . $key);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (SHINDIG-1391) Small improvements in Config class

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/SHINDIG-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Lindner resolved SHINDIG-1391.
-----------------------------------

    Fix Version/s: 2.0.0-RC1
       Resolution: Fixed

patch applied


> Small improvements in Config class
> ----------------------------------
>
>                 Key: SHINDIG-1391
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1391
>             Project: Shindig
>          Issue Type: Improvement
>          Components: PHP
>            Reporter: Bastian Hofmann
>             Fix For: 2.0.0-RC1
>
>
> - Loading of config files is now done with an absolute path which is quicker in php
> - better exception message if config key not found
> Index: php/src/common/Config.php
> ===================================================================
> 35c35
> <       include_once 'config/container.php';
> ---
> >       include_once realpath(dirname(__FILE__) . "/../../config") . '/container.php';
> 37c37
> <       $localConfigPath = realpath(dirname(__FILE__) . "/../../config/local.php");
> ---
> >       $localConfigPath = realpath(dirname(__FILE__) . "/../../config") . '/local.php';
> 64c64
> <       throw new ConfigException("Invalid Config Key");
> ---
> >       throw new ConfigException("Invalid Config Key " . $key);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.