You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@usergrid.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/01/12 01:25:40 UTC
[jira] [Commented] (USERGRID-1206) URLConnectionFactory not being
used in UGClient
[ https://issues.apache.org/jira/browse/USERGRID-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15092992#comment-15092992 ]
ASF GitHub Bot commented on USERGRID-1206:
------------------------------------------
GitHub user alphamu opened a pull request:
https://github.com/apache/usergrid/pull/463
USERGRID-1206 UGClient does not use URLConnectionFactory.
User DefaultURLConnectionFactory is not URLConnectionFactory is specified.
use urlConnectionFactory.openConnection(urlAsString) instead of new URL(urlAsString).openConnection();
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alphamu/usergrid USERGRID-1206
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/usergrid/pull/463.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #463
----
commit bd165fe159d2f51358de06efc6d8b36acfb8f292
Author: Ali Muzaffar <al...@muzaffar.me>
Date: 2016-01-12T00:23:28Z
USERGRID-1206 UGClient does not use URLConnectionFactory.
User DefaultURLConnectionFactory is not URLConnectionFactory is specified.
use urlConnectionFactory.openConnection(urlAsString) instead of new URL(urlAsString).openConnection();
----
> URLConnectionFactory not being used in UGClient
> -----------------------------------------------
>
> Key: USERGRID-1206
> URL: https://issues.apache.org/jira/browse/USERGRID-1206
> Project: Usergrid
> Issue Type: Bug
> Components: SDK-Android
> Affects Versions: 1.0
> Reporter: Ali Muzaffar
> Assignee: Ali Muzaffar
> Priority: Minor
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The UGClient class does not make use of the URLConnectionFactory.
> The DefaultURLConnectionFactory class should be used if not URLConnectionFactory is specified. Under doHttpRequest() the URLConnectionFactory.openConnection(urlAsString) should be used instead of creating a new URL connection manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)