You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2014/11/14 01:19:21 UTC
Review Request 28019: Show update page URL in the output for
beta-update start.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28019/
-----------------------------------------------------------
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Bugs: AURORA-766
https://issues.apache.org/jira/browse/AURORA-766
Repository: aurora
Description
-------
Show update page URL in the output for beta-update start.
Diffs
-----
src/main/python/apache/aurora/client/cli/context.py df9dc24a060ef551009f48687fe9ecd928ee04a4
src/main/python/apache/aurora/client/cli/update.py 30763920bbc0b7e7a19e9a1a873d72680b7f821b
src/test/python/apache/aurora/client/cli/test_supdate.py 97a9664a5230a7331bd7b784cbbc958d4c07cbb1
Diff: https://reviews.apache.org/r/28019/diff/
Testing
-------
./pants src/test/python/apache/aurora/client/cli/:all
./build-support/python/checkstyle-check src/
./build-support/python/isort-check src/
Thanks,
David McLaughlin
Re: Review Request 28019: Show update page URL in the output for
beta-update start.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28019/#review61386
-----------------------------------------------------------
Ship it!
Master (316f291) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 14, 2014, 1:44 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28019/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 1:44 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Bugs: AURORA-766
> https://issues.apache.org/jira/browse/AURORA-766
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Show update page URL in the output for beta-update start.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py df9dc24a060ef551009f48687fe9ecd928ee04a4
> src/main/python/apache/aurora/client/cli/update.py 30763920bbc0b7e7a19e9a1a873d72680b7f821b
> src/test/python/apache/aurora/client/cli/test_supdate.py 97a9664a5230a7331bd7b784cbbc958d4c07cbb1
>
> Diff: https://reviews.apache.org/r/28019/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/cli/:all
> ./build-support/python/checkstyle-check src/
> ./build-support/python/isort-check src/
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 28019: Show update page URL in the output for
beta-update start.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28019/#review61383
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Nov. 14, 2014, 1:44 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28019/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 1:44 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Bugs: AURORA-766
> https://issues.apache.org/jira/browse/AURORA-766
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Show update page URL in the output for beta-update start.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py df9dc24a060ef551009f48687fe9ecd928ee04a4
> src/main/python/apache/aurora/client/cli/update.py 30763920bbc0b7e7a19e9a1a873d72680b7f821b
> src/test/python/apache/aurora/client/cli/test_supdate.py 97a9664a5230a7331bd7b784cbbc958d4c07cbb1
>
> Diff: https://reviews.apache.org/r/28019/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/cli/:all
> ./build-support/python/checkstyle-check src/
> ./build-support/python/isort-check src/
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 28019: Show update page URL in the output for
beta-update start.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28019/#review61375
-----------------------------------------------------------
Ship it!
- Maxim Khutornenko
On Nov. 14, 2014, 1:44 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28019/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 1:44 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Bugs: AURORA-766
> https://issues.apache.org/jira/browse/AURORA-766
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Show update page URL in the output for beta-update start.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py df9dc24a060ef551009f48687fe9ecd928ee04a4
> src/main/python/apache/aurora/client/cli/update.py 30763920bbc0b7e7a19e9a1a873d72680b7f821b
> src/test/python/apache/aurora/client/cli/test_supdate.py 97a9664a5230a7331bd7b784cbbc958d4c07cbb1
>
> Diff: https://reviews.apache.org/r/28019/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/cli/:all
> ./build-support/python/checkstyle-check src/
> ./build-support/python/isort-check src/
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 28019: Show update page URL in the output for
beta-update start.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28019/
-----------------------------------------------------------
(Updated Nov. 14, 2014, 1:44 a.m.)
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Changes
-------
Simplify.
Bugs: AURORA-766
https://issues.apache.org/jira/browse/AURORA-766
Repository: aurora
Description
-------
Show update page URL in the output for beta-update start.
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/context.py df9dc24a060ef551009f48687fe9ecd928ee04a4
src/main/python/apache/aurora/client/cli/update.py 30763920bbc0b7e7a19e9a1a873d72680b7f821b
src/test/python/apache/aurora/client/cli/test_supdate.py 97a9664a5230a7331bd7b784cbbc958d4c07cbb1
Diff: https://reviews.apache.org/r/28019/diff/
Testing
-------
./pants src/test/python/apache/aurora/client/cli/:all
./build-support/python/checkstyle-check src/
./build-support/python/isort-check src/
Thanks,
David McLaughlin
Re: Review Request 28019: Show update page URL in the output for
beta-update start.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28019/#review61346
-----------------------------------------------------------
Ship it!
Master (254e175) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 14, 2014, 12:19 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28019/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 12:19 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Bugs: AURORA-766
> https://issues.apache.org/jira/browse/AURORA-766
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Show update page URL in the output for beta-update start.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py df9dc24a060ef551009f48687fe9ecd928ee04a4
> src/main/python/apache/aurora/client/cli/update.py 30763920bbc0b7e7a19e9a1a873d72680b7f821b
> src/test/python/apache/aurora/client/cli/test_supdate.py 97a9664a5230a7331bd7b784cbbc958d4c07cbb1
>
> Diff: https://reviews.apache.org/r/28019/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/cli/:all
> ./build-support/python/checkstyle-check src/
> ./build-support/python/isort-check src/
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 28019: Show update page URL in the output for
beta-update start.
Posted by David McLaughlin <da...@dmclaughlin.com>.
> On Nov. 14, 2014, 1:22 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, lines 83-85
> > <https://reviews.apache.org/r/28019/diff/1/?file=763026#file763026line83>
> >
> > How about combining the two into something like: "Job update has started. View update progress at %s"?
Done.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28019/#review61364
-----------------------------------------------------------
On Nov. 14, 2014, 12:19 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28019/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 12:19 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Bugs: AURORA-766
> https://issues.apache.org/jira/browse/AURORA-766
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Show update page URL in the output for beta-update start.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py df9dc24a060ef551009f48687fe9ecd928ee04a4
> src/main/python/apache/aurora/client/cli/update.py 30763920bbc0b7e7a19e9a1a873d72680b7f821b
> src/test/python/apache/aurora/client/cli/test_supdate.py 97a9664a5230a7331bd7b784cbbc958d4c07cbb1
>
> Diff: https://reviews.apache.org/r/28019/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/cli/:all
> ./build-support/python/checkstyle-check src/
> ./build-support/python/isort-check src/
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 28019: Show update page URL in the output for
beta-update start.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28019/#review61364
-----------------------------------------------------------
src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/28019/#comment102941>
How about combining the two into something like: "Job update has started. View update progress at %s"?
- Maxim Khutornenko
On Nov. 14, 2014, 12:19 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28019/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 12:19 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Bugs: AURORA-766
> https://issues.apache.org/jira/browse/AURORA-766
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Show update page URL in the output for beta-update start.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py df9dc24a060ef551009f48687fe9ecd928ee04a4
> src/main/python/apache/aurora/client/cli/update.py 30763920bbc0b7e7a19e9a1a873d72680b7f821b
> src/test/python/apache/aurora/client/cli/test_supdate.py 97a9664a5230a7331bd7b784cbbc958d4c07cbb1
>
> Diff: https://reviews.apache.org/r/28019/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/cli/:all
> ./build-support/python/checkstyle-check src/
> ./build-support/python/isort-check src/
>
>
> Thanks,
>
> David McLaughlin
>
>