You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "afters (JIRA)" <ji...@apache.org> on 2010/10/26 09:15:20 UTC
[jira] Created: (COUCHDB-925) altering 'doc' variable in map
function affects other map functions
altering 'doc' variable in map function affects other map functions
-------------------------------------------------------------------
Key: COUCHDB-925
URL: https://issues.apache.org/jira/browse/COUCHDB-925
Project: CouchDB
Issue Type: Bug
Affects Versions: 1.0.1
Environment: Erlang R13B03, Spidermonkey 1.7, Ubuntu 10.04
Reporter: afters
I have the following two map functions (v1.0.1):
function (doc) {
emit(doc.path[0], null);
}
function (doc) {
doc.path = [ 'an intruder from another view' ];
}
When the views are built, the first map function sees a 'doc' variable that
was changed by the second map function, and thus emits the key 'an intruder
from another view'.
The real documents remain untouched.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-925) altering 'doc' variable in map
function affects other map functions
Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934490#action_12934490 ]
Paul Joseph Davis commented on COUCHDB-925:
-------------------------------------------
Has this been tested with a spidermonkey that's actually broken? It looks fine to me but it might be a good idea to try and find one of the old versions to double check the behavior.
Regardless, I'm +1 on committing.
> altering 'doc' variable in map function affects other map functions
> -------------------------------------------------------------------
>
> Key: COUCHDB-925
> URL: https://issues.apache.org/jira/browse/COUCHDB-925
> Project: CouchDB
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Erlang R13B03, Spidermonkey 1.7, Ubuntu 10.04
> Reporter: afters
> Attachments: COUCHDB-925.patch
>
>
> I have the following two map functions (v1.0.1):
> function (doc) {
> emit(doc.path[0], null);
> }
> function (doc) {
> doc.path = [ 'an intruder from another view' ];
> }
> When the views are built, the first map function sees a 'doc' variable that
> was changed by the second map function, and thus emits the key 'an intruder
> from another view'.
> The real documents remain untouched.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-925) altering 'doc' variable in map
function affects other map functions
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filipe Manana updated COUCHDB-925:
----------------------------------
Attachment: COUCHDB-925.patch
Clearly, I haven't read the full thread before.
Paul is absolutely right.
After the last 2 fixes I made to the recursivelySeal function:
http://svn.apache.org/viewvc?view=revision&revision=1037213
http://svn.apache.org/viewvc?rev=1037246&view=rev
I propose the attached patch.
Does anyone has an objection?
> altering 'doc' variable in map function affects other map functions
> -------------------------------------------------------------------
>
> Key: COUCHDB-925
> URL: https://issues.apache.org/jira/browse/COUCHDB-925
> Project: CouchDB
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Erlang R13B03, Spidermonkey 1.7, Ubuntu 10.04
> Reporter: afters
> Attachments: COUCHDB-925.patch
>
>
> I have the following two map functions (v1.0.1):
> function (doc) {
> emit(doc.path[0], null);
> }
> function (doc) {
> doc.path = [ 'an intruder from another view' ];
> }
> When the views are built, the first map function sees a 'doc' variable that
> was changed by the second map function, and thus emits the key 'an intruder
> from another view'.
> The real documents remain untouched.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-925) altering 'doc' variable in map
function affects other map functions
Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925545#action_12925545 ]
Paul Joseph Davis commented on COUCHDB-925:
-------------------------------------------
It would appear that the error occurred on early versions of the 1.9.x branch of spidermonkey. It has since been patched into 1.9.1 and 1.9.2 Unfortunately there its not really easy to define what that means in terms of what people may have installed on their machines.
If someone wants to write a patch for this, it may be easiest to just seal objects and ignore the error, and then have a Futon tests that tells people whether or not it works. I'm not entirely certain if that's the best approach, but its the best I can think of right at this moment.
The original SM bug is here:
https://bugzilla.mozilla.org/show_bug.cgi?id=449657
> altering 'doc' variable in map function affects other map functions
> -------------------------------------------------------------------
>
> Key: COUCHDB-925
> URL: https://issues.apache.org/jira/browse/COUCHDB-925
> Project: CouchDB
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Erlang R13B03, Spidermonkey 1.7, Ubuntu 10.04
> Reporter: afters
>
> I have the following two map functions (v1.0.1):
> function (doc) {
> emit(doc.path[0], null);
> }
> function (doc) {
> doc.path = [ 'an intruder from another view' ];
> }
> When the views are built, the first map function sees a 'doc' variable that
> was changed by the second map function, and thus emits the key 'an intruder
> from another view'.
> The real documents remain untouched.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-925) altering 'doc' variable in map
function affects other map functions
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934145#action_12934145 ]
Filipe Manana commented on COUCHDB-925:
---------------------------------------
Maybe the following patch fixes that:
(trunk) -> http://svn.apache.org/viewvc?view=revision&revision=1037213
(1.0.x) -> http://svn.apache.org/viewvc?view=revision&revision=1037215
(1.1.x) -> http://svn.apache.org/viewvc?view=revision&revision=1037216
afters, are you willing to give it a try?
I'll try to write a test case in the meanwhile.
thanks
> altering 'doc' variable in map function affects other map functions
> -------------------------------------------------------------------
>
> Key: COUCHDB-925
> URL: https://issues.apache.org/jira/browse/COUCHDB-925
> Project: CouchDB
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Erlang R13B03, Spidermonkey 1.7, Ubuntu 10.04
> Reporter: afters
>
> I have the following two map functions (v1.0.1):
> function (doc) {
> emit(doc.path[0], null);
> }
> function (doc) {
> doc.path = [ 'an intruder from another view' ];
> }
> When the views are built, the first map function sees a 'doc' variable that
> was changed by the second map function, and thus emits the key 'an intruder
> from another view'.
> The real documents remain untouched.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-925) altering 'doc' variable in map
function affects other map functions
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12935715#action_12935715 ]
Filipe Manana commented on COUCHDB-925:
---------------------------------------
afters,
But you get an error message in the couch log, right?
Yes, I think it's intentional. As soon as a map function tries to modify a property of a document an exception is raised.
> altering 'doc' variable in map function affects other map functions
> -------------------------------------------------------------------
>
> Key: COUCHDB-925
> URL: https://issues.apache.org/jira/browse/COUCHDB-925
> Project: CouchDB
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Erlang R13B03, Spidermonkey 1.7, Ubuntu 10.04
> Reporter: afters
> Assignee: Filipe Manana
> Attachments: COUCHDB-925.patch
>
>
> I have the following two map functions (v1.0.1):
> function (doc) {
> emit(doc.path[0], null);
> }
> function (doc) {
> doc.path = [ 'an intruder from another view' ];
> }
> When the views are built, the first map function sees a 'doc' variable that
> was changed by the second map function, and thus emits the key 'an intruder
> from another view'.
> The real documents remain untouched.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-925) altering 'doc' variable in map
function affects other map functions
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filipe Manana updated COUCHDB-925:
----------------------------------
Attachment: (was: COUCHDB-925.patch)
> altering 'doc' variable in map function affects other map functions
> -------------------------------------------------------------------
>
> Key: COUCHDB-925
> URL: https://issues.apache.org/jira/browse/COUCHDB-925
> Project: CouchDB
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Erlang R13B03, Spidermonkey 1.7, Ubuntu 10.04
> Reporter: afters
> Attachments: COUCHDB-925.patch
>
>
> I have the following two map functions (v1.0.1):
> function (doc) {
> emit(doc.path[0], null);
> }
> function (doc) {
> doc.path = [ 'an intruder from another view' ];
> }
> When the views are built, the first map function sees a 'doc' variable that
> was changed by the second map function, and thus emits the key 'an intruder
> from another view'.
> The real documents remain untouched.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-925) altering 'doc' variable in map
function affects other map functions
Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Joseph Davis updated COUCHDB-925:
--------------------------------------
Skill Level: Regular Contributors Level (Easy to Medium)
This is because the object sealing was broken in Spidermonkey 1.7 for Array objects. To fix this we need to do the research on whether that bug has been fixed in newer versions and if so add it back to couchjs.
Also, JS tests should be added to test for this behaviour so that when people run the Futon tests they know whether their JS engine is properly sealing objects.
> altering 'doc' variable in map function affects other map functions
> -------------------------------------------------------------------
>
> Key: COUCHDB-925
> URL: https://issues.apache.org/jira/browse/COUCHDB-925
> Project: CouchDB
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Erlang R13B03, Spidermonkey 1.7, Ubuntu 10.04
> Reporter: afters
>
> I have the following two map functions (v1.0.1):
> function (doc) {
> emit(doc.path[0], null);
> }
> function (doc) {
> doc.path = [ 'an intruder from another view' ];
> }
> When the views are built, the first map function sees a 'doc' variable that
> was changed by the second map function, and thus emits the key 'an intruder
> from another view'.
> The real documents remain untouched.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (COUCHDB-925) altering 'doc' variable in map
function affects other map functions
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filipe Manana closed COUCHDB-925.
---------------------------------
Resolution: Fixed
Assignee: Filipe Manana
Latest patch applied to trunk, 1.0.x and 1.1.x.
Thanks everyone.
> altering 'doc' variable in map function affects other map functions
> -------------------------------------------------------------------
>
> Key: COUCHDB-925
> URL: https://issues.apache.org/jira/browse/COUCHDB-925
> Project: CouchDB
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Erlang R13B03, Spidermonkey 1.7, Ubuntu 10.04
> Reporter: afters
> Assignee: Filipe Manana
> Attachments: COUCHDB-925.patch
>
>
> I have the following two map functions (v1.0.1):
> function (doc) {
> emit(doc.path[0], null);
> }
> function (doc) {
> doc.path = [ 'an intruder from another view' ];
> }
> When the views are built, the first map function sees a 'doc' variable that
> was changed by the second map function, and thus emits the key 'an intruder
> from another view'.
> The real documents remain untouched.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-925) altering 'doc' variable in map
function affects other map functions
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filipe Manana updated COUCHDB-925:
----------------------------------
Attachment: COUCHDB-925.patch
> altering 'doc' variable in map function affects other map functions
> -------------------------------------------------------------------
>
> Key: COUCHDB-925
> URL: https://issues.apache.org/jira/browse/COUCHDB-925
> Project: CouchDB
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Erlang R13B03, Spidermonkey 1.7, Ubuntu 10.04
> Reporter: afters
> Attachments: COUCHDB-925.patch
>
>
> I have the following two map functions (v1.0.1):
> function (doc) {
> emit(doc.path[0], null);
> }
> function (doc) {
> doc.path = [ 'an intruder from another view' ];
> }
> When the views are built, the first map function sees a 'doc' variable that
> was changed by the second map function, and thus emits the key 'an intruder
> from another view'.
> The real documents remain untouched.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-925) altering 'doc' variable in map
function affects other map functions
Posted by "afters (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925526#action_12925526 ]
afters commented on COUCHDB-925:
--------------------------------
Looking at the 'Install.Unix' file, I was reminded that the SpiderMonkey 1.8 is a dependency.
If I understood your comment correctly, there's no much point for me to upgrade SM right now, as even if the problem were fixed there, a separate fix would still be needed in couch. Correct?
> altering 'doc' variable in map function affects other map functions
> -------------------------------------------------------------------
>
> Key: COUCHDB-925
> URL: https://issues.apache.org/jira/browse/COUCHDB-925
> Project: CouchDB
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Erlang R13B03, Spidermonkey 1.7, Ubuntu 10.04
> Reporter: afters
>
> I have the following two map functions (v1.0.1):
> function (doc) {
> emit(doc.path[0], null);
> }
> function (doc) {
> doc.path = [ 'an intruder from another view' ];
> }
> When the views are built, the first map function sees a 'doc' variable that
> was changed by the second map function, and thus emits the key 'an intruder
> from another view'.
> The real documents remain untouched.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-925) altering 'doc' variable in map
function affects other map functions
Posted by "Lukasz Mielicki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996930#comment-12996930 ]
Lukasz Mielicki commented on COUCHDB-925:
-----------------------------------------
Seems to still break with:
delete doc._rev;
delete doc._id;
> altering 'doc' variable in map function affects other map functions
> -------------------------------------------------------------------
>
> Key: COUCHDB-925
> URL: https://issues.apache.org/jira/browse/COUCHDB-925
> Project: CouchDB
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Erlang R13B03, Spidermonkey 1.7, Ubuntu 10.04
> Reporter: afters
> Assignee: Filipe Manana
> Attachments: COUCHDB-925.patch
>
>
> I have the following two map functions (v1.0.1):
> function (doc) {
> emit(doc.path[0], null);
> }
> function (doc) {
> doc.path = [ 'an intruder from another view' ];
> }
> When the views are built, the first map function sees a 'doc' variable that
> was changed by the second map function, and thus emits the key 'an intruder
> from another view'.
> The real documents remain untouched.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COUCHDB-925) altering 'doc' variable in map
function affects other map functions
Posted by "afters (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12935723#action_12935723 ]
afters commented on COUCHDB-925:
--------------------------------
You're right, it does. It's actually a pretty sane behaviour.
Thanks Filipe, and Paul.
> altering 'doc' variable in map function affects other map functions
> -------------------------------------------------------------------
>
> Key: COUCHDB-925
> URL: https://issues.apache.org/jira/browse/COUCHDB-925
> Project: CouchDB
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Erlang R13B03, Spidermonkey 1.7, Ubuntu 10.04
> Reporter: afters
> Assignee: Filipe Manana
> Attachments: COUCHDB-925.patch
>
>
> I have the following two map functions (v1.0.1):
> function (doc) {
> emit(doc.path[0], null);
> }
> function (doc) {
> doc.path = [ 'an intruder from another view' ];
> }
> When the views are built, the first map function sees a 'doc' variable that
> was changed by the second map function, and thus emits the key 'an intruder
> from another view'.
> The real documents remain untouched.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-925) altering 'doc' variable in map
function affects other map functions
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filipe Manana updated COUCHDB-925:
----------------------------------
Attachment: COUCHDB-925.patch
Updated patch: added a few more tests (for inner objects) and corrected a misspelled word in the warning message.
If nobody has an objection, I will commit it by tomorrow.
> altering 'doc' variable in map function affects other map functions
> -------------------------------------------------------------------
>
> Key: COUCHDB-925
> URL: https://issues.apache.org/jira/browse/COUCHDB-925
> Project: CouchDB
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Erlang R13B03, Spidermonkey 1.7, Ubuntu 10.04
> Reporter: afters
> Attachments: COUCHDB-925.patch
>
>
> I have the following two map functions (v1.0.1):
> function (doc) {
> emit(doc.path[0], null);
> }
> function (doc) {
> doc.path = [ 'an intruder from another view' ];
> }
> When the views are built, the first map function sees a 'doc' variable that
> was changed by the second map function, and thus emits the key 'an intruder
> from another view'.
> The real documents remain untouched.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-925) altering 'doc' variable in map
function affects other map functions
Posted by "Lukasz Mielicki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997137#comment-12997137 ]
Lukasz Mielicki commented on COUCHDB-925:
-----------------------------------------
Never mind. It raises exception as expected.
> altering 'doc' variable in map function affects other map functions
> -------------------------------------------------------------------
>
> Key: COUCHDB-925
> URL: https://issues.apache.org/jira/browse/COUCHDB-925
> Project: CouchDB
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Erlang R13B03, Spidermonkey 1.7, Ubuntu 10.04
> Reporter: afters
> Assignee: Filipe Manana
> Attachments: COUCHDB-925.patch
>
>
> I have the following two map functions (v1.0.1):
> function (doc) {
> emit(doc.path[0], null);
> }
> function (doc) {
> doc.path = [ 'an intruder from another view' ];
> }
> When the views are built, the first map function sees a 'doc' variable that
> was changed by the second map function, and thus emits the key 'an intruder
> from another view'.
> The real documents remain untouched.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (COUCHDB-925) altering 'doc' variable in map
function affects other map functions
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filipe Manana updated COUCHDB-925:
----------------------------------
Attachment: (was: COUCHDB-925.patch)
> altering 'doc' variable in map function affects other map functions
> -------------------------------------------------------------------
>
> Key: COUCHDB-925
> URL: https://issues.apache.org/jira/browse/COUCHDB-925
> Project: CouchDB
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Erlang R13B03, Spidermonkey 1.7, Ubuntu 10.04
> Reporter: afters
> Attachments: COUCHDB-925.patch
>
>
> I have the following two map functions (v1.0.1):
> function (doc) {
> emit(doc.path[0], null);
> }
> function (doc) {
> doc.path = [ 'an intruder from another view' ];
> }
> When the views are built, the first map function sees a 'doc' variable that
> was changed by the second map function, and thus emits the key 'an intruder
> from another view'.
> The real documents remain untouched.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-925) altering 'doc' variable in map
function affects other map functions
Posted by "afters (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12935706#action_12935706 ]
afters commented on COUCHDB-925:
--------------------------------
I've just seen it now, and tested latest 1.0.x branch with SM 1.7.
The views that don't manipulate their docs work fine, and the view that does manipulate its doc is empty. Is this intentional?
> altering 'doc' variable in map function affects other map functions
> -------------------------------------------------------------------
>
> Key: COUCHDB-925
> URL: https://issues.apache.org/jira/browse/COUCHDB-925
> Project: CouchDB
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Erlang R13B03, Spidermonkey 1.7, Ubuntu 10.04
> Reporter: afters
> Assignee: Filipe Manana
> Attachments: COUCHDB-925.patch
>
>
> I have the following two map functions (v1.0.1):
> function (doc) {
> emit(doc.path[0], null);
> }
> function (doc) {
> doc.path = [ 'an intruder from another view' ];
> }
> When the views are built, the first map function sees a 'doc' variable that
> was changed by the second map function, and thus emits the key 'an intruder
> from another view'.
> The real documents remain untouched.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.