[GitHub] [cxf] reta commented on a change in pull request #927: Merge Opensaml4 to Jakarta EE branch

[GitBox <gi...@apache.org>]

reta commented on a change in pull request #927:
URL: https://github.com/apache/cxf/pull/927#discussion_r838004445



##########
File path: rt/rs/security/oauth-parent/oauth2-saml/src/main/java/org/apache/cxf/rs/security/oauth2/saml/SamlOAuthValidator.java
##########
@@ -144,7 +145,7 @@ private void validateSubjectConfirmation(Message m,
                                              SubjectConfirmationData subjectConfData) {
         if (subjectConfData == null) {
             if (!subjectConfirmationDataRequired
-                && cs.getNotOnOrAfter() != null && !cs.getNotOnOrAfter().isBeforeNow()) {
+                && cs.getNotOnOrAfter() != null && !cs.getNotOnOrAfter().isBefore(Instant.now())) {

Review comment:
       @coheigea could you please address / clarify ^^ , thank you.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org