You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "CurtHagenlocher (via GitHub)" <gi...@apache.org> on 2023/07/21 20:58:41 UTC
[GitHub] [arrow] CurtHagenlocher opened a new pull request, #36818: GH-36815: [C#]: Enable net472 tests under Windows
CurtHagenlocher opened a new pull request, #36818:
URL: https://github.com/apache/arrow/pull/36818
### What changes are included in this PR?
The primary C# test project is updated to run for .NET 4.7.2 only on Windows platforms.
### Are these changes tested?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] CurtHagenlocher commented on pull request #36818: GH-36815: [C#]: Enable net472 tests under Windows
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #36818:
URL: https://github.com/apache/arrow/pull/36818#issuecomment-1646241811
Okay, this seems to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36818: GH-36815: [C#]: Enable net472 tests under Windows
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36818:
URL: https://github.com/apache/arrow/pull/36818#issuecomment-1648622132
@github-actions crossbow submit verify-rc-source-csharp-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36818: GH-36815: [C#]: Enable net472 tests under Windows
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36818:
URL: https://github.com/apache/arrow/pull/36818#issuecomment-1651005416
Ah, our RC verification script https://github.com/apache/arrow/blob/main/dev/release/verify-release-candidate.bat doesn't test the C# part...
We need to add it. Could you open an issue for it?
Does the following log show that this case was tested?
https://github.com/apache/arrow/actions/runs/5626539222/job/15247546402?pr=36818#step:6:68
```text
Test run for D:\a\arrow\arrow\csharp\artifacts\Apache.Arrow.Tests\Debug\net472\Apache.Arrow.Tests.dll (.NETFramework,Version=v4.7.2)
Microsoft (R) Test Execution Command Line Tool Version 17.6.3 (x64)
Copyright (c) Microsoft Corporation. All rights reserved.
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
Passed! - Failed: 0, Passed: 1110, Skipped: 0, Total: 1110, Duration: 5 s - Apache.Arrow.Tests.dll (net472)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36818: GH-36815: [C#]: Enable net472 tests under Windows
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36818:
URL: https://github.com/apache/arrow/pull/36818#issuecomment-1648801719
Revision: e81d15f243fdde539685eb66a269488e65538aa8
Submitted crossbow builds: [ursacomputing/crossbow @ actions-3dd808a59e](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3dd808a59e)
|Task|Status|
|----|------|
|verify-rc-source-windows|[](https://github.com/ursacomputing/crossbow/actions/runs/5651272363/job/15309104766)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36818: GH-36815: [C#]: Enable net472 tests under Windows
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36818:
URL: https://github.com/apache/arrow/pull/36818#issuecomment-1648800181
@github-actions crossbow submit verify-rc-source-windows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-36815: [C#]: Enable net472 tests under Windows [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36818:
URL: https://github.com/apache/arrow/pull/36818#issuecomment-1765428971
Revision: 438632fc37f0e387cb9972cba48be023064ba987
Submitted crossbow builds: [ursacomputing/crossbow @ actions-8a2a4f68be](https://github.com/ursacomputing/crossbow/branches/all?query=actions-8a2a4f68be)
|Task|Status|
|----|------|
|verify-rc-source-windows|[](https://github.com/ursacomputing/crossbow/actions/runs/6540500451/job/17760501162)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36818: GH-36815: [C#]: Enable net472 tests under Windows
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36818:
URL: https://github.com/apache/arrow/pull/36818#issuecomment-1646233601
:warning: GitHub issue #36815 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-36815: [C#]: Enable net472 tests under Windows [arrow]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #36818:
URL: https://github.com/apache/arrow/pull/36818#issuecomment-1765321806
I clearly should have come back to this before checking in the Duration change (which has now broken the .NET 4.7.2 build).
Opened #38298.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-36815: [C#]: Enable net472 tests under Windows [arrow]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher merged PR #36818:
URL: https://github.com/apache/arrow/pull/36818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36818: GH-36815: [C#]: Enable net472 tests under Windows
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36818:
URL: https://github.com/apache/arrow/pull/36818#issuecomment-1648625488
Revision: e81d15f243fdde539685eb66a269488e65538aa8
Submitted crossbow builds: [ursacomputing/crossbow @ actions-0e47458a7b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-0e47458a7b)
|Task|Status|
|----|------|
|verify-rc-source-csharp-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5649908980/job/15305228319)|
|verify-rc-source-csharp-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5649909141/job/15305228889)|
|verify-rc-source-csharp-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5649909576/job/15305230457)|
|verify-rc-source-csharp-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5649909896/job/15305231350)|
|verify-rc-source-csharp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5649909986/job/15305231766)|
|verify-rc-source-csharp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/5649909360/job/15305229830)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-36815: [C#]: Enable net472 tests under Windows [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36818:
URL: https://github.com/apache/arrow/pull/36818#issuecomment-1771779243
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 4011058f4a56bdcf160f46373355ffa0e22bcd2c.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/17879625729) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-36815: [C#]: Enable net472 tests under Windows [arrow]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #36818:
URL: https://github.com/apache/arrow/pull/36818#issuecomment-1765427133
@github-actions crossbow submit verify-rc-source-windows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org