You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/13 14:48:20 UTC
[jira] [Commented] (STORM-1966) Expand metric having Map type as
value into multiple metrics based on entries
[ https://issues.apache.org/jira/browse/STORM-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375141#comment-15375141 ]
ASF GitHub Bot commented on STORM-1966:
---------------------------------------
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1560
STORM-1966 Expand metric having Map type as value into multiple metrics based on entries
* populate metric before applying filter so that filter can play with populated metrics
* add relevant configs to metrics consumer registration and describe them to storm.config.yaml
* add unit test
Please refer https://issues.apache.org/jira/browse/STORM-1966 for more details.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1966
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1560.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1560
----
commit 31cba7f69a3ad7220eb9036bdd28a356cbb9c7df
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-07-13T08:23:26Z
STORM-1966 Expand metric having Map type as value into multiple metrics based on entries
* populate metric before applying filter so that filter can play with populated metrics
* add relevant configs to metrics consumer registration and describe them to storm.config.yaml
* add unit test
----
> Expand metric having Map type as value into multiple metrics based on entries
> -----------------------------------------------------------------------------
>
> Key: STORM-1966
> URL: https://issues.apache.org/jira/browse/STORM-1966
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Affects Versions: 2.0.0, 1.1.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> We're introducing "metrics filter" (STORM-1700) into Storm 1.1.0, which can give a control of volume and kinds of metrics to users.
> After playing with metrics, I found that most of built-in metrics in Storm (core and storm-kafka) are having Map as value which have been expected to be populated from Metrics Consumer. Since filter resides on metrics consumer bolt (not injected to metrics consumer) filter cannot know how metrics are populated, thus can't filter out some of populated metrics.
> For example, let's say we have metric which name is 'A' and value is \{"B": 1, "C": 2\}. For now we can't filter out 'A.C' and keep only 'A.B' since filter even doesn't know 'A' will be changed to 'A.B' and 'A.C'.
> Since well-known metrics consumer (like storm-graphite) already supports populating metrics from one level map of value, I'd like to support this from Storm side and apply filter to populated metrics.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)