Re: [I] Retire the Claude subscription OAuth path [maka]

["Joob1n (via GitHub)" <gi...@apache.org>]

Joob1n commented on issue #3143:
URL: https://github.com/apache/maka/issues/3143#issuecomment-5369349136

   Done in #3183, which merged on 2026-08-21. Closing this now — it stayed open past the merge, which risks reading as still-to-do.
   
   Every constraint this issue recorded is in place on `main`:
   
   - **The provider type stays registered.** `claude-subscription` is still in `PROVIDER_REGISTRY`, so `connection-catalog.json` still decodes for a workspace that once enrolled. It is unwired, not removed.
   - **An explicit `retired: true` marker**, rather than inferring retirement from `runtimeAdapter: 'unavailable'` — the distinction this issue asked for between "retired" and "never available".
   - **`OAUTH_LOGIN_PROVIDERS` narrowed** to `['openai-codex', 'xai-oauth']`.
   - **`RUNTIME_HOST_COMPATIBILITY_EPOCH` bumped** for that decode change.
   - **The three separately-revertible enforcement points are pinned**, which is the part this issue flagged as thin: `provider-catalog-contract.test.ts` asserts the retired set is exactly `['claude-subscription']`, so the unavailable adapter, the storage allow-list and the wire enum can no longer drift back one at a time with the suite green.
   
   Two follow-ups came out of it rather than being dropped:
   
   - `request_authorization_code` became producerless once this landed, exactly as predicted here. Tracked as #3219 and removed in #3399.
   - The tombstone invariant needed one more path: deleting a retained credential still bumped the retired row's revision, which could make deleting the connection itself fail as stale. #3415.
   
   The Consumer Terms reading in the description above was the reason given, and it is still worth a maintainer or counsel confirming before it is cited anywhere authoritative — closing this issue does not settle that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org