You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "tomtongue (via GitHub)" <gi...@apache.org> on 2025/04/16 04:57:39 UTC

[PR] Migrate Spark 3.4 ExtensionsTestBase-related tests for Snapshot manipulation, ChangeLogView and Distribution/Ordering [iceberg]

tomtongue opened a new pull request, #12807:
URL: https://github.com/apache/iceberg/pull/12807

   *Migrate Spark 3.4 tests based on JUnit 4 to Junit5 with AssertJ style. This is related to https://github.com/apache/iceberg/issues/7160*
   
   This PR migrates the below tests, which are related to extensions test base in Spark 3.4, into JUnit 5 with AssertJ. The following classes are included in this PR:
   
   * Snapshot Manipulation: 
     * `TestAncestorsOfProcedure` 
     * `TestCherrypickSnapshotProcedure` (Replace `import static org.assertj.core.api.AssertionsForClassTypes.assertThat;` with `Assertions.assertThat` because the previous one is only for Java 8 which has been deprecated in recent Iceberg verions)
     * `TestSetCurrentSnapshotProcedure` (Replace `AssertionsForClassTypes.assertThat` with `Assertions.assertThat` as well)
     * `TestRollbackToSnapshotProcedure` (Replace `AssertionsForClassTypes.assertThat` with `Assertions.assertThat`)
     * `TestRollbackToTimestampProcedure` (Replace `AssertionsForClassTypes.assertThat` with `Assertions.assertThat`)
   * Change log view
     * `TestChangelogTable` including the backport from 3.5 tests
     * `TestCreateChangelogViewProcedure`
   * Distribution and ordering:
     * `TestRequiredDistributionAndOrdering` 
     * `TestSetWriteDistributionAndOrdering` including the backport from https://github.com/apache/iceberg/pull/10774
   * Additional tests:
     * `TestCallStatementParser` 
     * `TestConflictValidation` 
     * `TestMetaColumnProjectionWithStageScan` 
     * `TestStoragePartitionedJoinsInRowLevelOperations` 
     * `TestSystemFunctionPushDownDQL`
     * `TestSystemFunctionPushDownInRowLevelOperations` 
     * `TestWriteAborts`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [PR] Migrate Spark 3.4 ExtensionsTestBase-related tests for Snapshot manipulation, ChangeLogView and Distribution/Ordering [iceberg]

Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #12807:
URL: https://github.com/apache/iceberg/pull/12807


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [PR] Migrate Spark 3.4 ExtensionsTestBase-related tests for Snapshot manipulation, ChangeLogView and Distribution/Ordering [iceberg]

Posted by "tomtongue (via GitHub)" <gi...@apache.org>.
tomtongue commented on PR #12807:
URL: https://github.com/apache/iceberg/pull/12807#issuecomment-2808322499

   The test `TestSerializedMetadata.testEmptyVariantMetadata` failed, which seems not related to this commit. Let me retry CI tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [PR] Migrate Spark 3.4 ExtensionsTestBase-related tests for Snapshot manipulation, ChangeLogView and Distribution/Ordering [iceberg]

Posted by "tomtongue (via GitHub)" <gi...@apache.org>.
tomtongue commented on PR #12807:
URL: https://github.com/apache/iceberg/pull/12807#issuecomment-2808812864

   @nastra When you have a moment, could you review this? One more PR is enough to complete the migration of extensions tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [PR] Migrate Spark 3.4 ExtensionsTestBase-related tests for Snapshot manipulation, ChangeLogView and Distribution/Ordering [iceberg]

Posted by "tomtongue (via GitHub)" <gi...@apache.org>.
tomtongue commented on PR #12807:
URL: https://github.com/apache/iceberg/pull/12807#issuecomment-2808932372

   @nastra Thanks so much for the review!!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org