You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by GitBox <gi...@apache.org> on 2020/12/28 01:56:15 UTC
[GitHub] [tika] PeterAlfredLee commented on a change in pull request #392: Simplify method CompressorParser#parse
PeterAlfredLee commented on a change in pull request #392:
URL: https://github.com/apache/tika/pull/392#discussion_r549189936
##########
File path: tika-parsers/tika-parsers-classic/tika-parsers-classic-modules/tika-parser-pkg-module/src/main/java/org/apache/tika/parser/pkg/CompressorParser.java
##########
@@ -213,22 +213,15 @@ public boolean decompressConcatenated(Metadata metadata) {
Metadata entrydata = new Metadata();
String name = metadata.get(TikaCoreProperties.RESOURCE_NAME_KEY);
if (name != null) {
- if (name.endsWith(".tbz")) {
- name = name.substring(0, name.length() - 4) + ".tar";
- } else if (name.endsWith(".tbz2")) {
- name = name.substring(0, name.length() - 5) + ".tar";
- } else if (name.endsWith(".bz")) {
- name = name.substring(0, name.length() - 3);
- } else if (name.endsWith(".bz2")) {
- name = name.substring(0, name.length() - 4);
- } else if (name.endsWith(".xz")) {
- name = name.substring(0, name.length() - 3);
- } else if (name.endsWith(".zlib")) {
- name = name.substring(0, name.length() - 5);
- } else if (name.endsWith(".pack")) {
- name = name.substring(0, name.length() - 5);
- } else if (name.endsWith(".br")) {
- name = name.substring(0, name.length() - 3);
+ if (name.endsWith(".tbz") || name.endsWith(".tbz2")) {
Review comment:
Well, I don't think this method would be reused in anyplace else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org