[GitHub] [spark] shivusondur commented on a change in pull request #24368: [SPARK-27464][CORE] Added Constant instead of referring string literal used from many places

[GitBox <gi...@apache.org>]

shivusondur commented on a change in pull request #24368: [SPARK-27464][CORE] Added Constant instead of referring string literal used from many places
URL: https://github.com/apache/spark/pull/24368#discussion_r275350902
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
 ##########
 @@ -1303,4 +1303,10 @@ package object config {
     .doc("Staging directory used while submitting applications.")
     .stringConf
     .createOptional
+
+  private[spark] val BUFFER_PAGESIZE = ConfigBuilder("spark.buffer.pageSize")
+    .doc("The amount of memory used per page in bytes")
+    .bytesConf(ByteUnit.BYTE)
 
 Review comment:
   @attilapiros 
   At the destination(for allocation of pagesize), we need in Byte unit only.
   And user can still configure with their values and unit. ex: 1k,1m,1g
   hope addressed your query.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org