[GitHub] [flink] JingGe commented on a diff in pull request #21065: [FLINK-29567][connector/common] Change numRecordsSend / numBytesSend / numRecordsSendError back to numRecordsOut / numBytesOut / numRecordsOutError in sink

[GitBox <gi...@apache.org>]

JingGe commented on code in PR #21065:
URL: https://github.com/apache/flink/pull/21065#discussion_r996758508


##########
flink-connectors/flink-connector-aws-kinesis-firehose/src/main/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkWriter.java:
##########
@@ -96,11 +96,7 @@ private static FirehoseAsyncClient createFirehoseClient(
                     RESOURCE_NOT_FOUND_EXCEPTION_CLASSIFIER,
                     getSdkClientMisconfiguredExceptionClassifier());
 
-    // deprecated, use numRecordsSendErrorsCounter instead.
-    @Deprecated private final Counter numRecordsOutErrorsCounter;
-
-    /* A counter for the total number of records that have encountered an error during put */
-    private final Counter numRecordsSendErrorsCounter;

Review Comment:
   Why remove it? `numRecordsOutErrorsCounter` is deprecated but still contains the errors counter.



##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java:
##########
@@ -71,10 +71,10 @@
     private final SinkWriterMetricGroup metrics;
 
     /* Counter for number of bytes this sink has attempted to send to the destination. */
-    private final Counter numBytesSendCounter;
+    private final Counter numBytesOutCounter;
 
     /* Counter for number of records this sink has attempted to send to the destination. */
-    private final Counter numRecordsSendCounter;

Review Comment:
   The decision is to point both `numXXXSendCounter` and `numXXXOutCounter` to the same number. Removing `numXXXSendCounter` breaks the backward compatibility with 1.15.x



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org