[GitHub] brodybits opened a new pull request #221: Improvements to src/main.js

[GitBox <gi...@apache.org>]

brodybits opened a new pull request #221: Improvements to src/main.js
URL: https://github.com/apache/cordova-coho/pull/221
 
 
   * Check that dependencies from `npm install` are present, in a utility module, with fixed directory path, before requiring anything else in `src/main.js`
   * lazyRequire in `src/lazy-require-util.js`
   * `var` -> `const` in the beginning
   
   Without the first item, running `cordova-coho/coho` without running `npm install` would give me the following output:
   ```
   internal/modules/cjs/loader.js:582
       throw err;
       ^
   
   Error: Cannot find module 'chalk'
       at Function.Module._resolveFilename (internal/modules/cjs/loader.js:580:15)
       at Function.Module._load (internal/modules/cjs/loader.js:506:25)
       at Module.require (internal/modules/cjs/loader.js:636:17)
       at require (internal/modules/cjs/helpers.js:20:18)
       at Object.<anonymous> (/Users/brodybits/Documents/cordova/cordova-coho/src/apputil.js:21:13)
       at Module._compile (internal/modules/cjs/loader.js:688:30)
       at Object.Module._extensions..js (internal/modules/cjs/loader.js:699:10)
       at Module.load (internal/modules/cjs/loader.js:598:32)
       at tryModuleLoad (internal/modules/cjs/loader.js:537:12)
       at Function.Module._load (internal/modules/cjs/loader.js:529:3)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org