[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4733: Add an integration test for LLC with PinotFS on non-local FS.

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #4733: Add an integration test for LLC with PinotFS on non-local FS.
URL: https://github.com/apache/incubator-pinot/pull/4733#discussion_r337306635
 
 

 ##########
 File path: pinot-common/src/main/java/org/apache/pinot/filesystem/PinotFS.java
 ##########
 @@ -101,7 +100,7 @@ public boolean move(URI srcUri, URI dstUri, boolean overwrite)
       }
     } else {
       // ensures the parent path of dst exists.
-      URI parentUri = Paths.get(dstUri).getParent().toUri();
+      URI parentUri = dstUri.getPath().endsWith("/") ? dstUri.resolve("..") : dstUri.resolve(".");
 
 Review comment:
   To me, this also has dependency on certain FS. Maybe better to add a `getParent()` API to `PinotFS`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org