[GitHub] [hadoop] martin-g commented on pull request #2723: HADOOP-13126 Add BrotliCodec based on Brotli4j library

[GitBox <gi...@apache.org>]

martin-g commented on PR #2723:
URL: https://github.com/apache/hadoop/pull/2723#issuecomment-1165466276

   What is the policy about using `Object#finalize()` in the `compress` package ?
   The last check fails because of 4 new usages of `finalize` in the Brotli[De]Compressor` classes.
   
   ```
   grep -rnHi finalize ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/
   ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/brotli/BrotliCompressor.java:251:  protected void finalize() throws Throwable {
   ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/brotli/BrotliCompressor.java:252:    super.finalize();
   ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/brotli/BrotliDecompressor.java:173:  protected void finalize() throws Throwable {
   ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/brotli/BrotliDecompressor.java:174:    super.finalize();
   ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/bzip2/CBZip2OutputStream.java:711:  protected void finalize() throws Throwable {
   ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/bzip2/CBZip2OutputStream.java:713:    super.finalize();
   ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/ZlibDecompressor.java:294:  protected void finalize() {
   ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zstd/ZStandardDecompressor.java:249:  protected void finalize() {
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org