You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2021/02/19 00:28:06 UTC

[GitHub] [guacamole-client] phreakocious commented on a change in pull request #592: GUACAMOLE-1292: prompt when closing the window/tab to avoid accidents with ctrl-w

phreakocious commented on a change in pull request #592:
URL: https://github.com/apache/guacamole-client/pull/592#discussion_r578841562



##########
File path: guacamole/src/main/webapp/app/client/controllers/clientController.js
##########
@@ -776,6 +783,8 @@ angular.module('client').controller('clientController', ['$scope', '$routeParams
 
         // Client error
         else if (connectionState === ManagedClientState.ConnectionState.CLIENT_ERROR) {
+            // Stop intercepting window close
+            $window.removeEventListener('beforeunload', ctrlwlistener, false);

Review comment:
       The new commit has moved this to a check in the event handler.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org