You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2015/12/11 19:33:31 UTC
Review Request 41261: Removing TCPConduit's Stub ID class
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41261/
-----------------------------------------------------------
Review request for geode and Darrel Schneider.
Repository: geode
Description
-------
This removes the Stub identifier class from TCPConduit. This simplifies the code since the DistributedMember IDs are propagated to all of the methods that require identifiers and these IDs have all of the information Stubs had.
The MembershipManager is also simplified since it doesn't have to keep complicated mappings between Stubs and DistributedMembers.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java 964845c8c6c14dc45e663502d600681b08368c5a
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/StartupMessage.java 96f8b6084f022a370a44b1ce1ed9d53a3c602d10
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/direct/DirectChannel.java f84813e4db75ed2beb03777b9a395c5808ced653
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/direct/MissingStubException.java 49b44860e3e060c0a53a3db340e90443048a40c6
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/MembershipManager.java 54b82a7efc5dad4f6b101eaa80b751ebee41b5f9
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java e5835c44afe92b92c8753b6e9528479900aec18f
gemfire-core/src/main/java/com/gemstone/gemfire/internal/i18n/ParentLocalizedStrings.java 7bb97b90e6addf5ace299a0696ed62decc66a00e
gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java f918812207c6df758d012c5be0089f8d6a4fada0
gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/ConnectionTable.java c8667979030cc335f987018e0c5b79cbc79547e6
gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/MemberShunnedException.java 5cd426f6b3dda6cb543fb8dbfe16f12b98861bb0
gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/ServerDelegate.java fd495d9bf78ff61d4ab4b0509822ee0cb84e28e0
gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/Stub.java 2e4b91bf98038475bf5376e5eaa3b6c22b704c76
gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/TCPConduit.java 12a03fd622084cf2cedeeab08307de7878bfe132
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/DistributionManagerDUnitTest.java 1f411bb08eb0d2470565d6e336535f1ff5cbf8a9
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManagerJUnitTest.java 44e1b463599ad50b894118e2d2e8dacffff9e586
gemfire-core/src/test/java/com/gemstone/gemfire/internal/tcp/ConnectionJUnitTest.java 78c462f48822411ae5e37e953d634fbef0abef44
Diff: https://reviews.apache.org/r/41261/diff/
Testing
-------
Thanks,
Bruce Schuchardt
Re: Review Request 41261: Removing TCPConduit's Stub ID class
Posted by Bruce Schuchardt <bs...@pivotal.io>.
> On Dec. 11, 2015, 6:49 p.m., Jianxia Chen wrote:
> > As long as there is no backward compatibility issue, it's fine.
There are no backward compatibility issues created by this work.
- Bruce
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41261/#review109982
-----------------------------------------------------------
On Dec. 11, 2015, 6:33 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41261/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2015, 6:33 p.m.)
>
>
> Review request for geode and Darrel Schneider.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This removes the Stub identifier class from TCPConduit. This simplifies the code since the DistributedMember IDs are propagated to all of the methods that require identifiers and these IDs have all of the information Stubs had.
>
> The MembershipManager is also simplified since it doesn't have to keep complicated mappings between Stubs and DistributedMembers.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java 964845c8c6c14dc45e663502d600681b08368c5a
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/StartupMessage.java 96f8b6084f022a370a44b1ce1ed9d53a3c602d10
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/direct/DirectChannel.java f84813e4db75ed2beb03777b9a395c5808ced653
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/direct/MissingStubException.java 49b44860e3e060c0a53a3db340e90443048a40c6
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/MembershipManager.java 54b82a7efc5dad4f6b101eaa80b751ebee41b5f9
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java e5835c44afe92b92c8753b6e9528479900aec18f
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/i18n/ParentLocalizedStrings.java 7bb97b90e6addf5ace299a0696ed62decc66a00e
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java f918812207c6df758d012c5be0089f8d6a4fada0
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/ConnectionTable.java c8667979030cc335f987018e0c5b79cbc79547e6
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/MemberShunnedException.java 5cd426f6b3dda6cb543fb8dbfe16f12b98861bb0
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/ServerDelegate.java fd495d9bf78ff61d4ab4b0509822ee0cb84e28e0
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/Stub.java 2e4b91bf98038475bf5376e5eaa3b6c22b704c76
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/TCPConduit.java 12a03fd622084cf2cedeeab08307de7878bfe132
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/DistributionManagerDUnitTest.java 1f411bb08eb0d2470565d6e336535f1ff5cbf8a9
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManagerJUnitTest.java 44e1b463599ad50b894118e2d2e8dacffff9e586
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/tcp/ConnectionJUnitTest.java 78c462f48822411ae5e37e953d634fbef0abef44
>
> Diff: https://reviews.apache.org/r/41261/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 41261: Removing TCPConduit's Stub ID class
Posted by Jianxia Chen <jc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41261/#review109982
-----------------------------------------------------------
Ship it!
As long as there is no backward compatibility issue, it's fine.
- Jianxia Chen
On Dec. 11, 2015, 6:33 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41261/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2015, 6:33 p.m.)
>
>
> Review request for geode and Darrel Schneider.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This removes the Stub identifier class from TCPConduit. This simplifies the code since the DistributedMember IDs are propagated to all of the methods that require identifiers and these IDs have all of the information Stubs had.
>
> The MembershipManager is also simplified since it doesn't have to keep complicated mappings between Stubs and DistributedMembers.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java 964845c8c6c14dc45e663502d600681b08368c5a
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/StartupMessage.java 96f8b6084f022a370a44b1ce1ed9d53a3c602d10
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/direct/DirectChannel.java f84813e4db75ed2beb03777b9a395c5808ced653
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/direct/MissingStubException.java 49b44860e3e060c0a53a3db340e90443048a40c6
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/MembershipManager.java 54b82a7efc5dad4f6b101eaa80b751ebee41b5f9
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java e5835c44afe92b92c8753b6e9528479900aec18f
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/i18n/ParentLocalizedStrings.java 7bb97b90e6addf5ace299a0696ed62decc66a00e
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java f918812207c6df758d012c5be0089f8d6a4fada0
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/ConnectionTable.java c8667979030cc335f987018e0c5b79cbc79547e6
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/MemberShunnedException.java 5cd426f6b3dda6cb543fb8dbfe16f12b98861bb0
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/ServerDelegate.java fd495d9bf78ff61d4ab4b0509822ee0cb84e28e0
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/Stub.java 2e4b91bf98038475bf5376e5eaa3b6c22b704c76
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/TCPConduit.java 12a03fd622084cf2cedeeab08307de7878bfe132
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/DistributionManagerDUnitTest.java 1f411bb08eb0d2470565d6e336535f1ff5cbf8a9
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManagerJUnitTest.java 44e1b463599ad50b894118e2d2e8dacffff9e586
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/tcp/ConnectionJUnitTest.java 78c462f48822411ae5e37e953d634fbef0abef44
>
> Diff: https://reviews.apache.org/r/41261/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bruce Schuchardt
>
>