You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/07/01 07:20:13 UTC

[GitHub] [iceberg] deadwind4 opened a new pull request, #5176: Fix typo in FlinkSink

deadwind4 opened a new pull request, #5176:
URL: https://github.com/apache/iceberg/pull/5176

   Change `should't` to `shouldn't` in FlinkSink class.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue commented on pull request #5176: Fix typo in FlinkSink

Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #5176:
URL: https://github.com/apache/iceberg/pull/5176#issuecomment-1173163853

   @deadwind4, can you rebase?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] deadwind4 commented on pull request #5176: Fix typo in FlinkSink

Posted by GitBox <gi...@apache.org>.
deadwind4 commented on PR #5176:
URL: https://github.com/apache/iceberg/pull/5176#issuecomment-1173208986

   @kbendick I have updated in other Flink versions. @rdblue I have rebased. Thanks a lot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] kbendick commented on pull request #5176: Fix typo in FlinkSink

Posted by GitBox <gi...@apache.org>.
kbendick commented on PR #5176:
URL: https://github.com/apache/iceberg/pull/5176#issuecomment-1173209429

   > @kbendick I have updated in other Flink versions. @rdblue I have rebased. Thanks a lot.
   
   Thanks @deadwind4!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue merged pull request #5176: Fix typo in FlinkSink

Posted by GitBox <gi...@apache.org>.
rdblue merged PR #5176:
URL: https://github.com/apache/iceberg/pull/5176


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org