You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/01/29 20:25:44 UTC

[kudu-CR] [clang-tidy] add modernize-{deprecated-headers,use-override}

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18182


Change subject: [clang-tidy] add modernize-{deprecated-headers,use-override}
......................................................................

[clang-tidy] add modernize-{deprecated-headers,use-override}

This patch adds modernize-deprecated-headers [1] and
modernize-use-override [2] checks for clang-tidy.

The former helps with changing the C-style headers into C++ ones: that
complements the IWYU functionality since the currently used IWYU version
suggests adding C-style headers, not C++ ones, and it's not clear what's
the timeline for addressing that.

The latter helps to remove extra 'virtual' keywords: I saw that in
a few recent patches posted for review, so I thought it would be nice
to automate catching those nits.

[1] https://releases.llvm.org/9.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/modernize-deprecated-headers.html
[2] https://releases.llvm.org/9.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/modernize-use-override.html

Change-Id: I04e8e2e19b185350969a2945326a7193d1e8f60d
---
M src/kudu/.clang-tidy
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/18182/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I04e8e2e19b185350969a2945326a7193d1e8f60d
Gerrit-Change-Number: 18182
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [clang-tidy] add modernize-{deprecated-headers,use-override}

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18182 )

Change subject: [clang-tidy] add modernize-{deprecated-headers,use-override}
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04e8e2e19b185350969a2945326a7193d1e8f60d
Gerrit-Change-Number: 18182
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Sat, 29 Jan 2022 23:55:08 +0000
Gerrit-HasComments: No

[kudu-CR] [clang-tidy] add modernize-{deprecated-headers,use-override}

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [clang-tidy] add modernize-{deprecated-headers,use-override}
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/18182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I04e8e2e19b185350969a2945326a7193d1e8f60d
Gerrit-Change-Number: 18182
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] [clang-tidy] add modernize-{deprecated-headers,use-override}

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18182 )

Change subject: [clang-tidy] add modernize-{deprecated-headers,use-override}
......................................................................


Patch Set 1: Verified+1

unrelated test failure in DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota (DEBUG build)


-- 
To view, visit http://gerrit.cloudera.org:8080/18182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04e8e2e19b185350969a2945326a7193d1e8f60d
Gerrit-Change-Number: 18182
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Sat, 29 Jan 2022 21:31:47 +0000
Gerrit-HasComments: No

[kudu-CR] [clang-tidy] add modernize-{deprecated-headers,use-override}

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18182 )

Change subject: [clang-tidy] add modernize-{deprecated-headers,use-override}
......................................................................

[clang-tidy] add modernize-{deprecated-headers,use-override}

This patch adds modernize-deprecated-headers [1] and
modernize-use-override [2] checks for clang-tidy.

The former helps with changing the C-style headers into C++ ones: that
complements the IWYU functionality since the currently used IWYU version
suggests adding C-style headers, not C++ ones, and it's not clear what's
the timeline for addressing that.

The latter helps to remove extra 'virtual' keywords: I saw that in
a few recent patches posted for review, so I thought it would be nice
to automate catching those nits.

[1] https://releases.llvm.org/9.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/modernize-deprecated-headers.html
[2] https://releases.llvm.org/9.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/modernize-use-override.html

Change-Id: I04e8e2e19b185350969a2945326a7193d1e8f60d
Reviewed-on: http://gerrit.cloudera.org:8080/18182
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/.clang-tidy
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Alexey Serbin: Verified
  Attila Bukor: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I04e8e2e19b185350969a2945326a7193d1e8f60d
Gerrit-Change-Number: 18182
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>