You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/31 07:11:42 UTC
[GitHub] [incubator-nuttx-apps] jerpelea opened a new pull request, #1178: mlearning: add Darknet (Open Source Neural Networks in C)
jerpelea opened a new pull request, #1178:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1178
## Summary
Darknet is an open source neural network framework written
in C and CUDA. It is fast, easy to install, and supports
CPU and GPU computation.
You Only Look Once (YOLO) is a state-of-the-art,
real-time object detection system
## Impact
ML
## Testing
ML
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1178: mlearning: add Darknet (Open Source Neural Networks in C)
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1178:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1178#discussion_r885460944
##########
mlearning/darknet/Makefile:
##########
@@ -0,0 +1,90 @@
+############################################################################
+# apps/mlearning/darknet/Makefile
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+include $(APPDIR)/Make.defs
+
+ifeq ($(CONFIG_DARKNET_YOLO),y)
+SRC = darknet/src
+
+CSRCS +=$(SRC)/gemm.c
+CSRCS +=$(SRC)/utils.c
+CSRCS +=$(SRC)/cuda.c
+CSRCS +=$(SRC)/deconvolutional_layer.c
+CSRCS +=$(SRC)/convolutional_layer.c
+CSRCS +=$(SRC)/list.c
+CSRCS +=$(SRC)/image.c
+CSRCS +=$(SRC)/activations.c
+CSRCS +=$(SRC)/im2col.c
+CSRCS +=$(SRC)/col2im.c
+CSRCS +=$(SRC)/blas.c
+CSRCS +=$(SRC)/crop_layer.c
+CSRCS +=$(SRC)/dropout_layer.c
+CSRCS +=$(SRC)/maxpool_layer.c
+CSRCS +=$(SRC)/softmax_layer.c
+CSRCS +=$(SRC)/data.c
+CSRCS +=$(SRC)/matrix.c
+CSRCS +=$(SRC)/network.c
+CSRCS +=$(SRC)/connected_layer.c
+CSRCS +=$(SRC)/cost_layer.c
+CSRCS +=$(SRC)/parser.c
+CSRCS +=$(SRC)/option_list.c
+CSRCS +=$(SRC)/detection_layer.c
+CSRCS +=$(SRC)/route_layer.c
+CSRCS +=$(SRC)/upsample_layer.c
+CSRCS +=$(SRC)/box.c
+CSRCS +=$(SRC)/normalization_layer.c
+CSRCS +=$(SRC)/avgpool_layer.c
+CSRCS +=$(SRC)/layer.c
+CSRCS +=$(SRC)/local_layer.c
+CSRCS +=$(SRC)/shortcut_layer.c
+CSRCS +=$(SRC)/logistic_layer.c
+CSRCS +=$(SRC)/activation_layer.c
+CSRCS +=$(SRC)/rnn_layer.c
+CSRCS +=$(SRC)/gru_layer.c
+CSRCS +=$(SRC)/crnn_layer.c
+CSRCS +=$(SRC)/demo.c
+CSRCS +=$(SRC)/batchnorm_layer.c
+CSRCS +=$(SRC)/region_layer.c
+CSRCS +=$(SRC)/reorg_layer.c
+CSRCS +=$(SRC)/tree.c
+CSRCS +=$(SRC)/lstm_layer.c
+CSRCS +=$(SRC)/l2norm_layer.c
+CSRCS +=$(SRC)/yolo_layer.c
+CSRCS +=$(SRC)/iseg_layer.c
+
+
+CFLAGS += -Wno-shadow -Wno-strict-prototypes -Wno-unknown-pragmas
+
+MODULE = $(CONFIG_DARKNET_YOLO)
+
+darknet.zip:
+ $(Q) curl -L https://github.com/pjreddie/darknet/archive/refs/heads/master.zip -o darknet.zip
Review Comment:
I mean, that `master` will be different from build to build. I think that using hash has better predictability, so then is can be changed to stable tag once it is available
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1178: mlearning: add Darknet (Open Source Neural Networks in C)
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1178:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1178#discussion_r885430829
##########
mlearning/darknet/Makefile:
##########
@@ -0,0 +1,90 @@
+############################################################################
+# apps/mlearning/darknet/Makefile
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+include $(APPDIR)/Make.defs
+
+ifeq ($(CONFIG_DARKNET_YOLO),y)
+SRC = darknet/src
+
+CSRCS +=$(SRC)/gemm.c
+CSRCS +=$(SRC)/utils.c
+CSRCS +=$(SRC)/cuda.c
+CSRCS +=$(SRC)/deconvolutional_layer.c
+CSRCS +=$(SRC)/convolutional_layer.c
+CSRCS +=$(SRC)/list.c
+CSRCS +=$(SRC)/image.c
+CSRCS +=$(SRC)/activations.c
+CSRCS +=$(SRC)/im2col.c
+CSRCS +=$(SRC)/col2im.c
+CSRCS +=$(SRC)/blas.c
+CSRCS +=$(SRC)/crop_layer.c
+CSRCS +=$(SRC)/dropout_layer.c
+CSRCS +=$(SRC)/maxpool_layer.c
+CSRCS +=$(SRC)/softmax_layer.c
+CSRCS +=$(SRC)/data.c
+CSRCS +=$(SRC)/matrix.c
+CSRCS +=$(SRC)/network.c
+CSRCS +=$(SRC)/connected_layer.c
+CSRCS +=$(SRC)/cost_layer.c
+CSRCS +=$(SRC)/parser.c
+CSRCS +=$(SRC)/option_list.c
+CSRCS +=$(SRC)/detection_layer.c
+CSRCS +=$(SRC)/route_layer.c
+CSRCS +=$(SRC)/upsample_layer.c
+CSRCS +=$(SRC)/box.c
+CSRCS +=$(SRC)/normalization_layer.c
+CSRCS +=$(SRC)/avgpool_layer.c
+CSRCS +=$(SRC)/layer.c
+CSRCS +=$(SRC)/local_layer.c
+CSRCS +=$(SRC)/shortcut_layer.c
+CSRCS +=$(SRC)/logistic_layer.c
+CSRCS +=$(SRC)/activation_layer.c
+CSRCS +=$(SRC)/rnn_layer.c
+CSRCS +=$(SRC)/gru_layer.c
+CSRCS +=$(SRC)/crnn_layer.c
+CSRCS +=$(SRC)/demo.c
+CSRCS +=$(SRC)/batchnorm_layer.c
+CSRCS +=$(SRC)/region_layer.c
+CSRCS +=$(SRC)/reorg_layer.c
+CSRCS +=$(SRC)/tree.c
+CSRCS +=$(SRC)/lstm_layer.c
+CSRCS +=$(SRC)/l2norm_layer.c
+CSRCS +=$(SRC)/yolo_layer.c
+CSRCS +=$(SRC)/iseg_layer.c
+
+
+CFLAGS += -Wno-shadow -Wno-strict-prototypes -Wno-unknown-pragmas
+
+MODULE = $(CONFIG_DARKNET_YOLO)
+
+darknet.zip:
+ $(Q) curl -L https://github.com/pjreddie/darknet/archive/refs/heads/master.zip -o darknet.zip
Review Comment:
let's use DARKNET_YOLO_VER here, so user can select different version through defconfig
##########
mlearning/darknet/Kconfig:
##########
@@ -0,0 +1,19 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config DARKNET_YOLO
+ bool "YOLO: Real-Time Object Detection"
+ default n
+ ---help---
+ You only look once (YOLO) is a state-of-the-art,
+ real-time object detection system
+
+if DARKNET_YOLO
+
+config DARKNET_YOLO_VER
+ string "DARKNET YOLO version"
+ default master
Review Comment:
change to “master”
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1178: mlearning: add Darknet (Open Source Neural Networks in C)
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1178:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1178#discussion_r885326419
##########
mlearning/darknet/Makefile:
##########
@@ -0,0 +1,90 @@
+############################################################################
+# apps/mlearning/darknet/Makefile
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+include $(APPDIR)/Make.defs
+
+ifeq ($(CONFIG_DARKNET_YOLO),y)
+SRC = darknet/src
+
+CSRCS +=$(SRC)/gemm.c
+CSRCS +=$(SRC)/utils.c
+CSRCS +=$(SRC)/cuda.c
+CSRCS +=$(SRC)/deconvolutional_layer.c
+CSRCS +=$(SRC)/convolutional_layer.c
+CSRCS +=$(SRC)/list.c
+CSRCS +=$(SRC)/image.c
+CSRCS +=$(SRC)/activations.c
+CSRCS +=$(SRC)/im2col.c
+CSRCS +=$(SRC)/col2im.c
+CSRCS +=$(SRC)/blas.c
+CSRCS +=$(SRC)/crop_layer.c
+CSRCS +=$(SRC)/dropout_layer.c
+CSRCS +=$(SRC)/maxpool_layer.c
+CSRCS +=$(SRC)/softmax_layer.c
+CSRCS +=$(SRC)/data.c
+CSRCS +=$(SRC)/matrix.c
+CSRCS +=$(SRC)/network.c
+CSRCS +=$(SRC)/connected_layer.c
+CSRCS +=$(SRC)/cost_layer.c
+CSRCS +=$(SRC)/parser.c
+CSRCS +=$(SRC)/option_list.c
+CSRCS +=$(SRC)/detection_layer.c
+CSRCS +=$(SRC)/route_layer.c
+CSRCS +=$(SRC)/upsample_layer.c
+CSRCS +=$(SRC)/box.c
+CSRCS +=$(SRC)/normalization_layer.c
+CSRCS +=$(SRC)/avgpool_layer.c
+CSRCS +=$(SRC)/layer.c
+CSRCS +=$(SRC)/local_layer.c
+CSRCS +=$(SRC)/shortcut_layer.c
+CSRCS +=$(SRC)/logistic_layer.c
+CSRCS +=$(SRC)/activation_layer.c
+CSRCS +=$(SRC)/rnn_layer.c
+CSRCS +=$(SRC)/gru_layer.c
+CSRCS +=$(SRC)/crnn_layer.c
+CSRCS +=$(SRC)/demo.c
+CSRCS +=$(SRC)/batchnorm_layer.c
+CSRCS +=$(SRC)/region_layer.c
+CSRCS +=$(SRC)/reorg_layer.c
+CSRCS +=$(SRC)/tree.c
+CSRCS +=$(SRC)/lstm_layer.c
+CSRCS +=$(SRC)/l2norm_layer.c
+CSRCS +=$(SRC)/yolo_layer.c
+CSRCS +=$(SRC)/iseg_layer.c
+
+
+CFLAGS += -Wno-shadow -Wno-strict-prototypes -Wno-unknown-pragmas
+
+MODULE = $(CONFIG_DARKNET_YOLO)
+
+darknet.zip:
+ $(Q) curl -L https://github.com/pjreddie/darknet/archive/refs/heads/master.zip -o darknet.zip
Review Comment:
Maybe adding git hash id is a good next step improvement to get better control of what is built
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea commented on a diff in pull request #1178: mlearning: add Darknet (Open Source Neural Networks in C)
Posted by GitBox <gi...@apache.org>.
jerpelea commented on code in PR #1178:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1178#discussion_r885447999
##########
mlearning/darknet/Makefile:
##########
@@ -0,0 +1,90 @@
+############################################################################
+# apps/mlearning/darknet/Makefile
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+include $(APPDIR)/Make.defs
+
+ifeq ($(CONFIG_DARKNET_YOLO),y)
+SRC = darknet/src
+
+CSRCS +=$(SRC)/gemm.c
+CSRCS +=$(SRC)/utils.c
+CSRCS +=$(SRC)/cuda.c
+CSRCS +=$(SRC)/deconvolutional_layer.c
+CSRCS +=$(SRC)/convolutional_layer.c
+CSRCS +=$(SRC)/list.c
+CSRCS +=$(SRC)/image.c
+CSRCS +=$(SRC)/activations.c
+CSRCS +=$(SRC)/im2col.c
+CSRCS +=$(SRC)/col2im.c
+CSRCS +=$(SRC)/blas.c
+CSRCS +=$(SRC)/crop_layer.c
+CSRCS +=$(SRC)/dropout_layer.c
+CSRCS +=$(SRC)/maxpool_layer.c
+CSRCS +=$(SRC)/softmax_layer.c
+CSRCS +=$(SRC)/data.c
+CSRCS +=$(SRC)/matrix.c
+CSRCS +=$(SRC)/network.c
+CSRCS +=$(SRC)/connected_layer.c
+CSRCS +=$(SRC)/cost_layer.c
+CSRCS +=$(SRC)/parser.c
+CSRCS +=$(SRC)/option_list.c
+CSRCS +=$(SRC)/detection_layer.c
+CSRCS +=$(SRC)/route_layer.c
+CSRCS +=$(SRC)/upsample_layer.c
+CSRCS +=$(SRC)/box.c
+CSRCS +=$(SRC)/normalization_layer.c
+CSRCS +=$(SRC)/avgpool_layer.c
+CSRCS +=$(SRC)/layer.c
+CSRCS +=$(SRC)/local_layer.c
+CSRCS +=$(SRC)/shortcut_layer.c
+CSRCS +=$(SRC)/logistic_layer.c
+CSRCS +=$(SRC)/activation_layer.c
+CSRCS +=$(SRC)/rnn_layer.c
+CSRCS +=$(SRC)/gru_layer.c
+CSRCS +=$(SRC)/crnn_layer.c
+CSRCS +=$(SRC)/demo.c
+CSRCS +=$(SRC)/batchnorm_layer.c
+CSRCS +=$(SRC)/region_layer.c
+CSRCS +=$(SRC)/reorg_layer.c
+CSRCS +=$(SRC)/tree.c
+CSRCS +=$(SRC)/lstm_layer.c
+CSRCS +=$(SRC)/l2norm_layer.c
+CSRCS +=$(SRC)/yolo_layer.c
+CSRCS +=$(SRC)/iseg_layer.c
+
+
+CFLAGS += -Wno-shadow -Wno-strict-prototypes -Wno-unknown-pragmas
+
+MODULE = $(CONFIG_DARKNET_YOLO)
+
+darknet.zip:
+ $(Q) curl -L https://github.com/pjreddie/darknet/archive/refs/heads/master.zip -o darknet.zip
Review Comment:
@pkarashchenko I prefer to use stable versions or tags but there is none for YOLO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1178: mlearning: add Darknet (Open Source Neural Networks in C)
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #1178:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1178#issuecomment-1183956731
@jerpelea do you have plan to support TensorFlow Lite?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1178: mlearning: add Darknet (Open Source Neural Networks in C)
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #1178:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #1178: mlearning: add Darknet (Open Source Neural Networks in C)
Posted by GitBox <gi...@apache.org>.
jerpelea commented on PR #1178:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1178#issuecomment-1183957664
@xiaoxiang781216 I am looking into it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org