You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "himanshuchawla0807-gif (via GitHub)" <gi...@apache.org> on 2026/10/20 08:29:12 UTC

[PR] Reveal selected Dag folders when names contain pipes [airflow]

himanshuchawla0807-gif opened a new pull request, #75196:
URL: https://github.com/apache/airflow/pull/75196

   Switching from bundle `a|b`, folder `c` to bundle `a`, folder `b|c` leaves the newly selected folder hidden because both selections produce the same delimiter-joined change key. Serialize the selection fields as a tuple so the new bundle and selected folder expand correctly.
   
   The regression checks selection and visibility after rerendering. It fails with the previous key construction and passes with this fix. Existing manual collapse/expansion behavior remains covered.
   
   Validation:
   - 31 folder component/tree tests passed.
   - Full UI suite: 1,981 tests across 242 files passed. The first run exposed an unrelated timing-sensitive variable-form assertion; its unchanged scoped rerun and the full confirmation run passed.
   - Simple-auth UI test passed.
   - ESLint, TypeScript, commit hooks, regular and manual prek checks passed, including production asset compilation.
   
   Before/after below use the actual `DagFolderTree` component with local fixture folders, rather than a deployed Airflow API server.
   
   | Before | After |
   | --- | --- |
   | ![Selected folder stays hidden](https://raw.githubusercontent.com/himanshuchawla0807-gif/airflow/1ec859d57cef2750a661cf23095b91099c1e14d7/selection-before.png) | ![Selected folder becomes visible](https://raw.githubusercontent.com/himanshuchawla0807-gif/airflow/1ec859d57cef2750a661cf23095b91099c1e14d7/selection-after.png) |
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — OpenAI Codex
   
   Generated-by: OpenAI Codex following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions).
   
   ---
   Drafted-by: OpenAI Codex (no human review before posting)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Reveal selected Dag folders when names contain pipes [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #75196:
URL: https://github.com/apache/airflow/pull/75196#issuecomment-6317122172

   ### Backport successfully created: v3-4-test
   
   Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
   the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
   
   In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
   
   <table>
           <tr>
           <th>Status</th>
           <th>Branch</th>
           <th>Result</th>
       </tr>
       <tr>
           <td>✅</td>
           <td>v3-4-test</td>
           <td><a href="https://github.com/apache/airflow/pull/75319"><img src="https://img.shields.io/badge/PR-75319-blue" alt="PR Link"></a></td>
       </tr>
   </table>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Reveal selected Dag folders when names contain pipes [airflow]

Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #75196:
URL: https://github.com/apache/airflow/pull/75196


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org