You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by st...@apache.org on 2026/05/02 00:57:37 UTC
(impala) branch master updated (a8715ea92 -> 89b3307e3)
This is an automated email from the ASF dual-hosted git repository.
asf-gitbox-commits pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
from a8715ea92 IMPALA-14938: Fix TestDisabledBlockLocations::test_iceberg_v3_smoke
new 5239fcf42 IMPALA-14932: Disable AI functions in FIPS mode
new 6d819c984 IMPALA-14939: Upgrade JaCoCo plugin version to 0.8.14
new 89b3307e3 IMPALA-13466/IMPALA-14935: Fix flakiness in TestHS2 long polling tests
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
be/src/exprs/ai-functions-ir.cc | 9 +++++++++
be/src/exprs/ai-functions.h | 1 +
fe/pom.xml | 2 +-
tests/hs2/test_hs2.py | 11 ++++++-----
4 files changed, 17 insertions(+), 6 deletions(-)
(impala) 03/03: IMPALA-13466/IMPALA-14935: Fix flakiness in TestHS2 long polling tests
Posted by st...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
asf-gitbox-commits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 89b3307e377351e6920929dec75ee08bfc9f5f4a
Author: Joe McDonnell <jo...@cloudera.com>
AuthorDate: Wed Apr 22 12:09:01 2026 -0700
IMPALA-13466/IMPALA-14935: Fix flakiness in TestHS2 long polling tests
TestHS2 has a couple tests that verify the timing of
operations with long polling. Specifically, both
test_long_polling_success and test_long_polling_failure
expect the call to take less than a second when using
a long_polling_time_ms of 10000. We've seen flakiness
for both of these test cases, so this loosens the bound
to 4 seconds. This is still enough to verify that long
polling is functioning.
Testing:
- Ran locally for 1000 iterations
Change-Id: I401e972bf9dd71dd0c8c11f9dbf575d3ed09b245
Reviewed-on: http://gerrit.cloudera.org:8080/24225
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
tests/hs2/test_hs2.py | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/tests/hs2/test_hs2.py b/tests/hs2/test_hs2.py
index f7a887b9b..359b8d37e 100644
--- a/tests/hs2/test_hs2.py
+++ b/tests/hs2/test_hs2.py
@@ -389,10 +389,11 @@ class TestHS2(HS2TestSuite):
assert get_operation_status_resp.operationState == \
TCLIService.TOperationState.FINISHED_STATE
# The long polling wait must have been interrupted by the completion, so it should
- # not come anywhere close to waiting the full 10 seconds. 1 second is not a very
- # tight time bound.
+ # not come anywhere close to waiting the full 10 seconds. Most of the time this
+ # completes within 1 second, but there are outliers that can be ~2.5 seconds. Set
+ # a loose time bound of 4 seconds.
time_diff = end_time - start_time
- assert time_diff < 1
+ assert time_diff < 4
# Fetch the results so the query completes successfully
fetch_results_req = TCLIService.TFetchResultsReq()
@@ -456,8 +457,8 @@ class TestHS2(HS2TestSuite):
# The long polling wait must have been interrupted by the error, so it should
# not come anywhere close to waiting the full 10 seconds. This is a very short
- # statement, so it should hit the error within 1 second.
- assert end_time - start_time < 1.0
+ # statement, so it should hit the error within 4 seconds.
+ assert end_time - start_time < 4.0
@needs_session()
def test_malformed_get_operation_status(self):
(impala) 02/03: IMPALA-14939: Upgrade JaCoCo plugin version to 0.8.14
Posted by st...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
asf-gitbox-commits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 6d819c9849ddf72fb9de231ff776e4cc05eef0c8
Author: Peter Rozsa <pr...@cloudera.com>
AuthorDate: Fri May 1 17:26:24 2026 +0200
IMPALA-14939: Upgrade JaCoCo plugin version to 0.8.14
This patch upgrades JaCoCo code coverage plugin version to 0.8.14 as
Java 17 based builds are failing with the 0.7.6.201602180812 version.
Tests:
- manually validated that JaCoCo agent starts properly during code
coverage tests.
Change-Id: I7a6889891bdf8510e30725a20cbaef37c2ef3352
Reviewed-on: http://gerrit.cloudera.org:8080/24256
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
fe/pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fe/pom.xml b/fe/pom.xml
index b3cfdf9d2..2f6313d90 100644
--- a/fe/pom.xml
+++ b/fe/pom.xml
@@ -767,7 +767,7 @@ under the License.
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
- <version>0.7.6.201602180812</version>
+ <version>0.8.14</version>
<executions>
<execution>
<id>prepare-jacoco-agent</id>
(impala) 01/03: IMPALA-14932: Disable AI functions in FIPS mode
Posted by st...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
asf-gitbox-commits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 5239fcf427b9570c3491889f2b69c59d50001592
Author: yida.wu <yi...@cloudera.com>
AuthorDate: Mon Apr 27 21:28:21 2026 -0700
IMPALA-14932: Disable AI functions in FIPS mode
Impala AI functions ai_generate_text and ai_generate_text_default
rely on JCEKS for credential or simply plain, which are not
FIPS-approved.
Add a check to return a clear error to disable these functions in
FIPS mode.
Tests:
Ran exhaustive tests.
Manually test in a FIPS cluster and return the error as expected.
Change-Id: I8d217fb0a7320a131f09abf00cc272961c5696b2
Reviewed-on: http://gerrit.cloudera.org:8080/24244
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Yida Wu <wy...@gmail.com>
---
be/src/exprs/ai-functions-ir.cc | 9 +++++++++
be/src/exprs/ai-functions.h | 1 +
2 files changed, 10 insertions(+)
diff --git a/be/src/exprs/ai-functions-ir.cc b/be/src/exprs/ai-functions-ir.cc
index 6f4772caf..782f149ec 100644
--- a/be/src/exprs/ai-functions-ir.cc
+++ b/be/src/exprs/ai-functions-ir.cc
@@ -26,6 +26,7 @@
#include "common/compiler-util.h"
#include "exprs/ai-functions.h"
+#include "util/openssl-util.h"
using namespace impala_udf;
using boost::algorithm::trim;
@@ -53,6 +54,9 @@ const string AiFunctions::AI_GENERATE_TXT_N_OVERRIDE_FORBIDDEN_ERROR =
"Invalid override, 'n' must be of integer type and have value 1";
const string AiFunctions::AI_GENERATE_TXT_COMMON_ERROR_PREFIX =
"AI Generate Text Error: ";
+const string AiFunctions::AI_GENERATE_TXT_FIPS_UNSUPPORTED_ERROR =
+ AiFunctions::AI_GENERATE_TXT_COMMON_ERROR_PREFIX
+ + "This function is disabled in FIPS mode";
string AiFunctions::ai_api_key_;
const char* AiFunctions::OPEN_AI_REQUEST_FIELD_CONTENT_TYPE_HEADER =
"Content-Type: application/json";
@@ -210,6 +214,11 @@ StringVal AiFunctions::AiGenerateTextHelper(FunctionContext* ctx,
const StringVal& endpoint, const StringVal& prompt, const StringVal& model,
const StringVal& auth_credential, const StringVal& platform_params,
const StringVal& impala_options) {
+ DCHECK(ctx != nullptr);
+ if (UNLIKELY(IsFIPSMode())) {
+ ctx->SetError(AI_GENERATE_TXT_FIPS_UNSUPPORTED_ERROR.c_str());
+ return StringVal::null();
+ }
string_view endpoint_sv(FLAGS_ai_endpoint);
// endpoint validation
if (!fastpath && endpoint.ptr != nullptr && endpoint.len != 0) {
diff --git a/be/src/exprs/ai-functions.h b/be/src/exprs/ai-functions.h
index 85a6e1b48..fa96f3a82 100644
--- a/be/src/exprs/ai-functions.h
+++ b/be/src/exprs/ai-functions.h
@@ -37,6 +37,7 @@ class AiFunctions {
static const string AI_GENERATE_TXT_MSG_OVERRIDE_FORBIDDEN_ERROR;
static const string AI_GENERATE_TXT_N_OVERRIDE_FORBIDDEN_ERROR;
static const string AI_GENERATE_TXT_COMMON_ERROR_PREFIX;
+ static const string AI_GENERATE_TXT_FIPS_UNSUPPORTED_ERROR;
static const char* OPEN_AI_REQUEST_FIELD_CONTENT_TYPE_HEADER;
static const char* OPEN_AI_REQUEST_AUTH_HEADER;
static const char* AZURE_OPEN_AI_REQUEST_AUTH_HEADER;