You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Freeman Fang (JIRA)" <ji...@apache.org> on 2010/08/04 10:30:23 UTC

[jira] Created: (KARAF-140) Modifying properties and saving them via the Config Console removes comments in the original file

Modifying properties and saving them via the Config Console removes comments in the original file
-------------------------------------------------------------------------------------------------

                 Key: KARAF-140
                 URL: https://issues.apache.org/jira/browse/KARAF-140
             Project: Karaf
          Issue Type: Improvement
    Affects Versions: 2.0.0
            Reporter: Freeman Fang
             Fix For: 2.2.0




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (KARAF-140) Modifying properties and saving them via the Config Console removes comments in the original file

Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KARAF-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899850#action_12899850 ] 

Freeman Fang commented on KARAF-140:
------------------------------------

Hi Guillaume,

Absolutely this minimal solution is more neat and better.
Thanks

Freeman

> Modifying properties and saving them via the Config Console removes comments in the original file
> -------------------------------------------------------------------------------------------------
>
>                 Key: KARAF-140
>                 URL: https://issues.apache.org/jira/browse/KARAF-140
>             Project: Karaf
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Freeman Fang
>            Assignee: Guillaume Nodet
>             Fix For: 2.2.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (KARAF-140) Modifying properties and saving them via the Config Console removes comments in the original file

Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KARAF-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895180#action_12895180 ] 

Freeman Fang commented on KARAF-140:
------------------------------------

seems we can use org.apache.commons.configuration.PropertiesConfiguration instead of java.util.Properties to do it

> Modifying properties and saving them via the Config Console removes comments in the original file
> -------------------------------------------------------------------------------------------------
>
>                 Key: KARAF-140
>                 URL: https://issues.apache.org/jira/browse/KARAF-140
>             Project: Karaf
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Freeman Fang
>            Assignee: Freeman Fang
>             Fix For: 2.2.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (KARAF-140) Modifying properties and saving them via the Config Console removes comments in the original file

Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Freeman Fang resolved KARAF-140.
--------------------------------

    Resolution: Fixed

commit fix
http://svn.apache.org/viewvc?rev=984712&view=rev

> Modifying properties and saving them via the Config Console removes comments in the original file
> -------------------------------------------------------------------------------------------------
>
>                 Key: KARAF-140
>                 URL: https://issues.apache.org/jira/browse/KARAF-140
>             Project: Karaf
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Freeman Fang
>            Assignee: Freeman Fang
>             Fix For: 2.2.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (KARAF-140) Modifying properties and saving them via the Config Console removes comments in the original file

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guillaume Nodet reopened KARAF-140:
-----------------------------------

      Assignee: Guillaume Nodet  (was: Freeman Fang)

Commons-config drags way too many code imho, i'll rewrite a small class to do that in a minimal way.

> Modifying properties and saving them via the Config Console removes comments in the original file
> -------------------------------------------------------------------------------------------------
>
>                 Key: KARAF-140
>                 URL: https://issues.apache.org/jira/browse/KARAF-140
>             Project: Karaf
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Freeman Fang
>            Assignee: Guillaume Nodet
>             Fix For: 2.2.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (KARAF-140) Modifying properties and saving them via the Config Console removes comments in the original file

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guillaume Nodet resolved KARAF-140.
-----------------------------------

    Resolution: Fixed

	M	assembly/src/main/filtered-resources/features.xml
	A	shell/config/src/main/java/org/apache/karaf/shell/config/Properties.java
	M	shell/config/src/main/java/org/apache/karaf/shell/config/UpdateCommand.java
	A	shell/config/src/test/java/org/apache/karaf/shell/config/PropertiesTest.java
Committed r986279


> Modifying properties and saving them via the Config Console removes comments in the original file
> -------------------------------------------------------------------------------------------------
>
>                 Key: KARAF-140
>                 URL: https://issues.apache.org/jira/browse/KARAF-140
>             Project: Karaf
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Freeman Fang
>            Assignee: Guillaume Nodet
>             Fix For: 2.2.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (KARAF-140) Modifying properties and saving them via the Config Console removes comments in the original file

Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Freeman Fang reassigned KARAF-140:
----------------------------------

    Assignee: Freeman Fang

> Modifying properties and saving them via the Config Console removes comments in the original file
> -------------------------------------------------------------------------------------------------
>
>                 Key: KARAF-140
>                 URL: https://issues.apache.org/jira/browse/KARAF-140
>             Project: Karaf
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Freeman Fang
>            Assignee: Freeman Fang
>             Fix For: 2.2.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.