You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2026/04/27 11:32:28 UTC

(skywalking) 02/02: runtime-rule: fix javadoc dead links and drop unused empty-static dir

This is an automated email from the ASF dual-hosted git repository.

wu-sheng pushed a commit to branch feature/runtime-rule-hot-update
in repository https://gitbox.apache.org/repos/asf/skywalking.git

commit 1c0f67412b056fda7cb83d6347a4b70456c15cff
Author: Wu Sheng <wu...@foxmail.com>
AuthorDate: Mon Apr 27 19:32:04 2026 +0800

    runtime-rule: fix javadoc dead links and drop unused empty-static dir
    
    Whole-project javadoc:javadoc surfaced a handful of stale {@link} targets:
    - LalRuleEngine: LalCompileException → EngineCompileException
    - MalRuleEngine: MetricConvert FQN was the v1 package, switched to v2
    - RuntimeRuleClusterClient: MainRouter#mainFor → MainRouter#mainClient
    - RuntimeRuleService: import DSLRuntimeDelete so the {@link} resolves
    
    Also delete test/e2e-v2/cases/runtime-rule-storage-matrix/empty-static —
    the .gitkeep placeholders and the dir itself are unused (no e2e config
    references them) and trip the license-header check.
    
    Verified locally: full-project mvn install + javadoc:javadoc clean,
    checkstyle clean, license-eye clean, and 111 runtime-rule UTs pass.
    ITs require JDK 11 to avoid a JDK 25 / Protobuf 4 init issue —
    CI runs them on JDK 11 in the runtime-rule-integration-test job.
---
 .../server/receiver/runtimerule/cluster/RuntimeRuleClusterClient.java | 2 +-
 .../oap/server/receiver/runtimerule/engine/lal/LalRuleEngine.java     | 4 ++--
 .../oap/server/receiver/runtimerule/engine/mal/MalRuleEngine.java     | 2 +-
 .../oap/server/receiver/runtimerule/rest/RuntimeRuleService.java      | 1 +
 .../cases/runtime-rule-storage-matrix/empty-static/lal/.gitkeep       | 0
 .../runtime-rule-storage-matrix/empty-static/otel-rules/.gitkeep      | 0
 6 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/oap-server/server-receiver-plugin/skywalking-runtime-rule-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/runtimerule/cluster/RuntimeRuleClusterClient.java b/oap-server/server-receiver-plugin/skywalking-runtime-rule-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/runtimerule/cluster/RuntimeRuleClusterClient.java
index 1416d0311b..985f6149c7 100644
--- a/oap-server/server-receiver-plugin/skywalking-runtime-rule-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/runtimerule/cluster/RuntimeRuleClusterClient.java
+++ b/oap-server/server-receiver-plugin/skywalking-runtime-rule-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/runtimerule/cluster/RuntimeRuleClusterClient.java
@@ -158,7 +158,7 @@ public final class RuntimeRuleClusterClient {
 
     /**
      * Forward a write request to the main node for {@code (catalog, name)}. The caller has
-     * already computed the main via {@link MainRouter#mainFor}. Locates the
+     * already computed the main via {@link MainRouter#mainClient}. Locates the
      * {@link RemoteClient} whose address matches {@code mainAddr} and issues the RPC.
      *
      * <p>Uses a longer deadline than Suspend / Resume because the forwarded workflow on the
diff --git a/oap-server/server-receiver-plugin/skywalking-runtime-rule-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/runtimerule/engine/lal/LalRuleEngine.java b/oap-server/server-receiver-plugin/skywalking-runtime-rule-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/runtimerule/engine/lal/LalRuleEngine.java
index 369775176f..79ddfffd41 100644
--- a/oap-server/server-receiver-plugin/skywalking-runtime-rule-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/runtimerule/engine/lal/LalRuleEngine.java
+++ b/oap-server/server-receiver-plugin/skywalking-runtime-rule-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/runtimerule/engine/lal/LalRuleEngine.java
@@ -289,8 +289,8 @@ public final class LalRuleEngine implements RuleEngine<LalApplyContext> {
      * Applied's entries become the gap. Old keys not in the partial set are still owned by
      * the old Applied (appliedLal[key] never swapped) so they keep serving.
      *
-     * <p>The orchestrator passes the partial set on the {@link CompiledDSL} via {@link
-     * LalCompileException}; we extract it from the wrapper context. Idempotent.
+     * <p>The orchestrator passes the partial set on the {@link CompiledDSL} via
+     * {@link EngineCompileException}; we extract it from the wrapper context. Idempotent.
      */
     @Override
     public void rollback(final CompiledDSL compiled, final LalApplyContext ctx) {
diff --git a/oap-server/server-receiver-plugin/skywalking-runtime-rule-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/runtimerule/engine/mal/MalRuleEngine.java b/oap-server/server-receiver-plugin/skywalking-runtime-rule-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/runtimerule/engine/mal/MalRuleEngine.java
index 7a0894c6bc..c37875e493 100644
--- a/oap-server/server-receiver-plugin/skywalking-runtime-rule-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/runtimerule/engine/mal/MalRuleEngine.java
+++ b/oap-server/server-receiver-plugin/skywalking-runtime-rule-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/runtimerule/engine/mal/MalRuleEngine.java
@@ -436,7 +436,7 @@ public final class MalRuleEngine implements RuleEngine<MalApplyContext> {
 
     /**
      * Atomic in-memory swap: install the new {@code Applied} in {@code appliedMal[key]},
-     * publish the freshly-compiled {@link org.apache.skywalking.oap.meter.analyzer.MetricConvert}
+     * publish the freshly-compiled {@link org.apache.skywalking.oap.meter.analyzer.v2.MetricConvert}
      * to the owning receiver's converter registry, retire the displaced classloader (STRUCTURAL
      * / NEW only — FILTER_ONLY's old loader's Metrics classes are still the live storage
      * target so it stays), and drive alarm-window reset for affected metric names.
diff --git a/oap-server/server-receiver-plugin/skywalking-runtime-rule-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/runtimerule/rest/RuntimeRuleService.java b/oap-server/server-receiver-plugin/skywalking-runtime-rule-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/runtimerule/rest/RuntimeRuleService.java
index d689cc78ce..825ea159cc 100644
--- a/oap-server/server-receiver-plugin/skywalking-runtime-rule-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/runtimerule/rest/RuntimeRuleService.java
+++ b/oap-server/server-receiver-plugin/skywalking-runtime-rule-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/runtimerule/rest/RuntimeRuleService.java
@@ -58,6 +58,7 @@ import org.apache.skywalking.oap.server.receiver.runtimerule.cluster.v1.ForwardR
 import org.apache.skywalking.oap.server.receiver.runtimerule.cluster.v1.SuspendAck;
 import org.apache.skywalking.oap.server.receiver.runtimerule.cluster.v1.SuspendState;
 import org.apache.skywalking.oap.server.receiver.runtimerule.reconcile.DSLManager;
+import org.apache.skywalking.oap.server.receiver.runtimerule.reconcile.DSLRuntimeDelete;
 import org.apache.skywalking.oap.server.receiver.runtimerule.reconcile.DSLScriptKey;
 import org.apache.skywalking.oap.server.receiver.runtimerule.reconcile.SuspendResult;
 import org.apache.skywalking.oap.server.receiver.runtimerule.state.AppliedRuleScript;
diff --git a/test/e2e-v2/cases/runtime-rule-storage-matrix/empty-static/lal/.gitkeep b/test/e2e-v2/cases/runtime-rule-storage-matrix/empty-static/lal/.gitkeep
deleted file mode 100644
index e69de29bb2..0000000000
diff --git a/test/e2e-v2/cases/runtime-rule-storage-matrix/empty-static/otel-rules/.gitkeep b/test/e2e-v2/cases/runtime-rule-storage-matrix/empty-static/otel-rules/.gitkeep
deleted file mode 100644
index e69de29bb2..0000000000