You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/18 04:19:32 UTC
[GitHub] [tvm] slyubomirsky opened a new issue #7129: [Relay][Documentation] Documentation for relay.stack appears incorrect
slyubomirsky opened a new issue #7129:
URL: https://github.com/apache/tvm/issues/7129
The documentation for [`tvm.relay.stack`](https://tvm.apache.org/docs/api/python/relay/index.html#tvm.relay.stack) states that its input can be either a list of Relay expressions or a tuple. However, if you give a Relay expression with a tuple output as an input to `tvm.relay.stack`, this will result in a Python type error, as the function [first tries to coerce the input into a Python list](https://github.com/apache/tvm/blob/6b9b8986bdf94834f3c19c0dc3c2841ac77d46fc/python/tvm/relay/op/tensor.py#L1119). The functionality should either be made to match the documentation or the documentation should be corrected to reflect the intended use.
@hogepodge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi closed issue #7129: [Relay][Documentation] Behavior of relay.stack does not appear to match documentation
Posted by GitBox <gi...@apache.org>.
masahi closed issue #7129:
URL: https://github.com/apache/tvm/issues/7129
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] slyubomirsky commented on issue #7129: [Relay][Documentation] Behavior of relay.stack does not appear to match documentation
Posted by GitBox <gi...@apache.org>.
slyubomirsky commented on issue #7129:
URL: https://github.com/apache/tvm/issues/7129#issuecomment-747862152
It appears this can be easily fixed with some changes to the Python binding for `stack`. I will PR a fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] slyubomirsky edited a comment on issue #7129: [Relay][Documentation] Behavior of relay.stack does not appear to match documentation
Posted by GitBox <gi...@apache.org>.
slyubomirsky edited a comment on issue #7129:
URL: https://github.com/apache/tvm/issues/7129#issuecomment-747862152
It appears this can be easily fixed with some changes to the Python binding for `stack`. I will PR a fix. (See #7130)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] slyubomirsky commented on issue #7129: [Relay][Documentation] Behavior of relay.stack does not appear to match documentation
Posted by GitBox <gi...@apache.org>.
slyubomirsky commented on issue #7129:
URL: https://github.com/apache/tvm/issues/7129#issuecomment-747872960
In retrospect, it is conceivable that the documentation did correctly note that the input must be a list or a tuple literal, but I would argue that restricting the possible input in this way defies user expectations. Also the fix was very easy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org