You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "HappenLee (via GitHub)" <gi...@apache.org> on 2025/11/18 03:42:02 UTC
[PR] [performance](agg) support count push agg in no null column [doris]
HappenLee opened a new pull request, #58103:
URL: https://github.com/apache/doris/pull/58103
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [performance](agg) support count push agg in no null column [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58103:
URL: https://github.com/apache/doris/pull/58103#issuecomment-3544982692
<details>
<summary>TPC-DS: <b>Total hot run time: 187645 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 13cce98243109aacac48326c407b12be722ff938, data reload: false
query1 1010 390 396 390
query2 6555 1648 1655 1648
query3 6776 223 221 221
query4 27149 23319 22942 22942
query5 4429 693 533 533
query6 360 261 242 242
query7 4665 513 313 313
query8 315 268 255 255
query9 8723 2934 2908 2908
query10 484 353 313 313
query11 15968 15067 14802 14802
query12 192 131 120 120
query13 1711 597 455 455
query14 11144 9390 9339 9339
query15 209 189 175 175
query16 7494 683 513 513
query17 1260 745 618 618
query18 2015 411 348 348
query19 206 208 184 184
query20 140 129 132 129
query21 218 133 116 116
query22 4007 4026 3938 3938
query23 33873 32956 32877 32877
query24 8098 2370 2416 2370
query25 584 534 459 459
query26 1241 285 172 172
query27 2735 511 368 368
query28 4362 2241 2214 2214
query29 791 629 497 497
query30 301 231 203 203
query31 937 813 737 737
query32 96 83 88 83
query33 593 412 370 370
query34 841 841 518 518
query35 816 840 770 770
query36 944 990 908 908
query37 126 124 98 98
query38 3599 3529 3471 3471
query39 1495 1450 1426 1426
query40 233 138 127 127
query41 64 60 61 60
query42 130 119 120 119
query43 481 494 452 452
query44 1265 804 795 795
query45 184 182 175 175
query46 880 999 667 667
query47 1796 1775 1698 1698
query48 397 425 331 331
query49 764 514 413 413
query50 668 681 409 409
query51 3876 3921 3891 3891
query52 121 117 108 108
query53 255 276 207 207
query54 337 315 293 293
query55 92 96 96 96
query56 345 337 340 337
query57 1164 1184 1113 1113
query58 309 293 289 289
query59 2413 2686 2402 2402
query60 364 373 349 349
query61 158 150 187 150
query62 796 699 671 671
query63 236 200 199 199
query64 4384 1158 888 888
query65 4024 3938 3947 3938
query66 1133 424 343 343
query67 15056 14861 15033 14861
query68 5144 979 641 641
query69 507 339 310 310
query70 1331 1329 1171 1171
query71 435 344 331 331
query72 5812 4863 4995 4863
query73 642 584 372 372
query74 8847 9234 8579 8579
query75 3313 3245 2800 2800
query76 3281 1119 779 779
query77 523 428 356 356
query78 9566 9884 8851 8851
query79 1552 900 616 616
query80 1771 635 577 577
query81 565 260 219 219
query82 426 165 141 141
query83 375 270 313 270
query84 254 104 91 91
query85 919 486 444 444
query86 389 334 299 299
query87 3744 3684 3612 3612
query88 2835 2239 2207 2207
query89 383 333 297 297
query90 1741 237 228 228
query91 177 164 132 132
query92 80 80 75 75
query93 1266 992 683 683
query94 714 440 312 312
query95 430 342 332 332
query96 489 590 276 276
query97 2898 2946 2849 2849
query98 240 224 217 217
query99 1321 1366 1291 1291
Total cold run time: 270357 ms
Total hot run time: 187645 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [performance](agg) support count push agg in no null column [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #58103:
URL: https://github.com/apache/doris/pull/58103#issuecomment-3545716619
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [performance](agg) support count push agg in no null column [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58103:
URL: https://github.com/apache/doris/pull/58103#issuecomment-3544993148
<details>
<summary>ClickBench: <b>Total hot run time: 27.43 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 13cce98243109aacac48326c407b12be722ff938, data reload: false
query1 0.06 0.05 0.05
query2 0.09 0.04 0.04
query3 0.25 0.08 0.08
query4 1.61 0.11 0.11
query5 0.28 0.24 0.24
query6 1.20 0.64 0.64
query7 0.03 0.03 0.02
query8 0.05 0.05 0.04
query9 0.58 0.54 0.51
query10 0.57 0.57 0.57
query11 0.16 0.10 0.11
query12 0.15 0.12 0.12
query13 0.62 0.60 0.60
query14 1.00 0.99 0.99
query15 0.86 0.83 0.84
query16 0.40 0.40 0.39
query17 1.01 1.04 1.07
query18 0.21 0.19 0.20
query19 1.93 1.75 1.78
query20 0.02 0.01 0.02
query21 15.43 0.20 0.13
query22 5.07 0.06 0.05
query23 15.73 0.24 0.09
query24 2.50 1.26 0.41
query25 0.08 0.06 0.06
query26 0.14 0.12 0.14
query27 0.06 0.05 0.05
query28 4.37 1.19 0.94
query29 12.55 3.84 3.27
query30 0.29 0.14 0.13
query31 2.82 0.59 0.39
query32 3.24 0.55 0.48
query33 3.04 3.08 3.03
query34 15.64 5.18 4.54
query35 4.58 4.57 4.57
query36 0.67 0.50 0.49
query37 0.10 0.06 0.06
query38 0.07 0.04 0.04
query39 0.04 0.03 0.03
query40 0.17 0.15 0.14
query41 0.09 0.03 0.03
query42 0.04 0.03 0.03
query43 0.04 0.04 0.03
Total cold run time: 97.84 s
Total hot run time: 27.43 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [performance](agg) support count push agg in no null column [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #58103:
URL: https://github.com/apache/doris/pull/58103#issuecomment-3545716454
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [performance](agg) support count push agg in no null column [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee merged PR #58103:
URL: https://github.com/apache/doris/pull/58103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [performance](agg) support count push agg in no null column [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #58103:
URL: https://github.com/apache/doris/pull/58103#issuecomment-3544893180
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [performance](agg) support count push agg in no null column [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #58103:
URL: https://github.com/apache/doris/pull/58103#issuecomment-3544889030
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [performance](agg) support count push agg in no null column [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58103:
URL: https://github.com/apache/doris/pull/58103#issuecomment-3544960609
<details>
<summary>TPC-H: <b>Total hot run time: 34169 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 13cce98243109aacac48326c407b12be722ff938, data reload: false
------ Round 1 ----------------------------------
q1 17592 5159 4956 4956
q2 2004 320 210 210
q3 10295 1277 691 691
q4 10249 945 391 391
q5 7540 2394 2360 2360
q6 185 164 135 135
q7 901 782 645 645
q8 9333 1564 1144 1144
q9 6730 5068 5110 5068
q10 6866 2220 1788 1788
q11 485 313 282 282
q12 349 375 229 229
q13 17813 3673 3048 3048
q14 234 242 223 223
q15 593 512 501 501
q16 1033 1009 938 938
q17 572 868 375 375
q18 7423 7205 7117 7117
q19 1094 936 565 565
q20 366 354 225 225
q21 3859 3234 2352 2352
q22 1054 1017 926 926
Total cold run time: 106570 ms
Total hot run time: 34169 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5006 4974 5000 4974
q2 265 327 225 225
q3 2182 2655 2342 2342
q4 1374 1774 1355 1355
q5 4198 4343 4519 4343
q6 221 170 139 139
q7 1998 2019 1900 1900
q8 2641 2713 2538 2538
q9 7311 7207 7266 7207
q10 3027 3232 2858 2858
q11 596 528 496 496
q12 685 767 603 603
q13 3511 4043 3446 3446
q14 300 318 287 287
q15 528 496 508 496
q16 1045 1115 1069 1069
q17 1160 1601 1392 1392
q18 8066 7798 7714 7714
q19 845 854 949 854
q20 1969 2018 1793 1793
q21 4858 4356 4375 4356
q22 1090 1034 1007 1007
Total cold run time: 52876 ms
Total hot run time: 51394 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [performance](agg) support count push agg in no null column [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58103:
URL: https://github.com/apache/doris/pull/58103#issuecomment-3545065113
# FE UT Coverage Report
Increment line coverage ` 56.52% (13/23)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58103_13cce98243109aacac48326c407b12be722ff938/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58103_13cce98243109aacac48326c407b12be722ff938/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org