You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Igor V Chebykin (JIRA)" <ji...@apache.org> on 2006/11/16 11:35:38 UTC
[jira] Created: (HARMONY-2207) [drlvm][ipf] auto constants
folding/propagation and few minor low level optimizations
[drlvm][ipf] auto constants folding/propagation and few minor low level optimizations
-------------------------------------------------------------------------------------
Key: HARMONY-2207
URL: http://issues.apache.org/jira/browse/HARMONY-2207
Project: Harmony
Issue Type: Improvement
Components: DRLVM
Environment: SUSE 9, ia64
Reporter: Igor V Chebykin
IpfCodeLayouter.cpp
completers for branches changed
IpfOpndManager.h
IpfOpndManager.cpp
imm for heapbase and vtablebase added
IpfCfg.h
isGReg() and isFReg() functions added
IpfEmitter.h
IpfType.h
IPF_ASSERT minor changes
isGReg() and isFReg() added
IpfInstCodeSelector.cpp
auto constant folding/propagation added
completers for branches changed
converting float to int32 optimized
register allocation optimized
IpfEmitter.cpp
ignored pseudo-insts removing added before emitting
bundling changed
IpfVerifier.cpp
minor change for debugging support
IpfEncoder.cpp
bug fixed
IpfType.cpp
constant folding/propagation support added
IpfCodeGenerator.cpp
minor change
isGReg() and isFReg() added
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2207) [drlvm][ipf] auto constants
folding/propagation and few minor low level optimizations
Posted by "Egor Pasko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2207?page=comments#action_12450726 ]
Egor Pasko commented on HARMONY-2207:
-------------------------------------
Igor, the patch is good and interesting reading. Please, ipdate it with tabs
converted to spaces (you have them in Emitter::bundling())
There are some minor questions that I want to ask:
(1)
+ // 6 pass: code optimizing
+ // TODO: delete if block
+ if (false && LOG_ON) {
+ checkForDualIssueBundles();
+ }
+
Did you put these lines by mistake or they have some hidden meaning? please
comment on it.
(2)
Why do you always use IPF_ASSERT? that is:
#define IPF_ASSERT(condition) if (VERIFY_ON && !(condition)) { IPF_ERR << (#condition) << endl; }
why not wipe this redundant "if" out in release mode? "if"s are not fast on IPF :)
(3)
Why do you add f0 as an operand to the FP multiply instruction? isn't it
redundant?
(4)
Are you going to transform STL containers to MemoryManager based ones soon?
for example:
vm/jitrino/src/codegenerator/ipf/include/IpfType.h:209:typedef bitset< NUM_G_REG > RegBitSet;
(5)
what is the patch queue that I need to apply to build on IPF? :)
> [drlvm][ipf] auto constants folding/propagation and few minor low level optimizations
> -------------------------------------------------------------------------------------
>
> Key: HARMONY-2207
> URL: http://issues.apache.org/jira/browse/HARMONY-2207
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Environment: SUSE 9, ia64
> Reporter: Igor V Chebykin
> Assigned To: Alexey Varlamov
> Attachments: patch.txt
>
>
> IpfCodeLayouter.cpp
> completers for branches changed
> IpfOpndManager.h
> IpfOpndManager.cpp
> imm for heapbase and vtablebase added
> IpfCfg.h
> isGReg() and isFReg() functions added
> IpfEmitter.h
> IpfType.h
> IPF_ASSERT minor changes
> isGReg() and isFReg() added
> IpfInstCodeSelector.cpp
> auto constant folding/propagation added
> completers for branches changed
> converting float to int32 optimized
> register allocation optimized
> IpfEmitter.cpp
> ignored pseudo-insts removing added before emitting
> bundling changed
> IpfVerifier.cpp
> minor change for debugging support
> IpfEncoder.cpp
> bug fixed
> IpfType.cpp
> constant folding/propagation support added
> IpfCodeGenerator.cpp
> minor change
> isGReg() and isFReg() added
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2207) [drlvm][ipf] auto constants
folding/propagation and few minor low level optimizations
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2207?page=comments#action_12450384 ]
Alexey Varlamov commented on HARMONY-2207:
------------------------------------------
Igor, if you did any checks/testing for the patch, please specify such info. It will speed up things a bit.
> [drlvm][ipf] auto constants folding/propagation and few minor low level optimizations
> -------------------------------------------------------------------------------------
>
> Key: HARMONY-2207
> URL: http://issues.apache.org/jira/browse/HARMONY-2207
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Environment: SUSE 9, ia64
> Reporter: Igor V Chebykin
> Assigned To: Alexey Varlamov
> Attachments: patch.txt
>
>
> IpfCodeLayouter.cpp
> completers for branches changed
> IpfOpndManager.h
> IpfOpndManager.cpp
> imm for heapbase and vtablebase added
> IpfCfg.h
> isGReg() and isFReg() functions added
> IpfEmitter.h
> IpfType.h
> IPF_ASSERT minor changes
> isGReg() and isFReg() added
> IpfInstCodeSelector.cpp
> auto constant folding/propagation added
> completers for branches changed
> converting float to int32 optimized
> register allocation optimized
> IpfEmitter.cpp
> ignored pseudo-insts removing added before emitting
> bundling changed
> IpfVerifier.cpp
> minor change for debugging support
> IpfEncoder.cpp
> bug fixed
> IpfType.cpp
> constant folding/propagation support added
> IpfCodeGenerator.cpp
> minor change
> isGReg() and isFReg() added
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2207) [drlvm][ipf] auto constants
folding/propagation and few minor low level optimizations
Posted by "Igor V Chebykin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2207?page=all ]
Igor V Chebykin updated HARMONY-2207:
-------------------------------------
Attachment: patch.txt
> [drlvm][ipf] auto constants folding/propagation and few minor low level optimizations
> -------------------------------------------------------------------------------------
>
> Key: HARMONY-2207
> URL: http://issues.apache.org/jira/browse/HARMONY-2207
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Environment: SUSE 9, ia64
> Reporter: Igor V Chebykin
> Attachments: patch.txt
>
>
> IpfCodeLayouter.cpp
> completers for branches changed
> IpfOpndManager.h
> IpfOpndManager.cpp
> imm for heapbase and vtablebase added
> IpfCfg.h
> isGReg() and isFReg() functions added
> IpfEmitter.h
> IpfType.h
> IPF_ASSERT minor changes
> isGReg() and isFReg() added
> IpfInstCodeSelector.cpp
> auto constant folding/propagation added
> completers for branches changed
> converting float to int32 optimized
> register allocation optimized
> IpfEmitter.cpp
> ignored pseudo-insts removing added before emitting
> bundling changed
> IpfVerifier.cpp
> minor change for debugging support
> IpfEncoder.cpp
> bug fixed
> IpfType.cpp
> constant folding/propagation support added
> IpfCodeGenerator.cpp
> minor change
> isGReg() and isFReg() added
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-2207) [drlvm][ipf] auto constants
folding/propagation and few minor low level optimizations
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2207?page=all ]
Alexey Varlamov reassigned HARMONY-2207:
----------------------------------------
Assignee: Alexey Varlamov
> [drlvm][ipf] auto constants folding/propagation and few minor low level optimizations
> -------------------------------------------------------------------------------------
>
> Key: HARMONY-2207
> URL: http://issues.apache.org/jira/browse/HARMONY-2207
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Environment: SUSE 9, ia64
> Reporter: Igor V Chebykin
> Assigned To: Alexey Varlamov
> Attachments: patch.txt
>
>
> IpfCodeLayouter.cpp
> completers for branches changed
> IpfOpndManager.h
> IpfOpndManager.cpp
> imm for heapbase and vtablebase added
> IpfCfg.h
> isGReg() and isFReg() functions added
> IpfEmitter.h
> IpfType.h
> IPF_ASSERT minor changes
> isGReg() and isFReg() added
> IpfInstCodeSelector.cpp
> auto constant folding/propagation added
> completers for branches changed
> converting float to int32 optimized
> register allocation optimized
> IpfEmitter.cpp
> ignored pseudo-insts removing added before emitting
> bundling changed
> IpfVerifier.cpp
> minor change for debugging support
> IpfEncoder.cpp
> bug fixed
> IpfType.cpp
> constant folding/propagation support added
> IpfCodeGenerator.cpp
> minor change
> isGReg() and isFReg() added
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2207) [drlvm][ipf] auto constants
folding/propagation and few minor low level optimizations
Posted by "Igor V Chebykin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2207?page=comments#action_12450386 ]
Igor V Chebykin commented on HARMONY-2207:
------------------------------------------
Alexey,
thank you for the reminder and sorry for my inattentionю
I have tested jitrino on Itanium2 and all is OK (at least specjvm98 passed)
No ia32 and em64 testing:
- the patch is for jitrino/src/codegenerator/ipf/** files only, so ia32 and em64 are not changed.
Thanks,
Igor.
> [drlvm][ipf] auto constants folding/propagation and few minor low level optimizations
> -------------------------------------------------------------------------------------
>
> Key: HARMONY-2207
> URL: http://issues.apache.org/jira/browse/HARMONY-2207
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Environment: SUSE 9, ia64
> Reporter: Igor V Chebykin
> Assigned To: Alexey Varlamov
> Attachments: patch.txt
>
>
> IpfCodeLayouter.cpp
> completers for branches changed
> IpfOpndManager.h
> IpfOpndManager.cpp
> imm for heapbase and vtablebase added
> IpfCfg.h
> isGReg() and isFReg() functions added
> IpfEmitter.h
> IpfType.h
> IPF_ASSERT minor changes
> isGReg() and isFReg() added
> IpfInstCodeSelector.cpp
> auto constant folding/propagation added
> completers for branches changed
> converting float to int32 optimized
> register allocation optimized
> IpfEmitter.cpp
> ignored pseudo-insts removing added before emitting
> bundling changed
> IpfVerifier.cpp
> minor change for debugging support
> IpfEncoder.cpp
> bug fixed
> IpfType.cpp
> constant folding/propagation support added
> IpfCodeGenerator.cpp
> minor change
> isGReg() and isFReg() added
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira