You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/03/18 06:01:41 UTC
[GitHub] [drill] luocooong opened a new pull request #2497: DRILL-8165: Upgrade liquibase because of CVE-2022-0839
luocooong opened a new pull request #2497:
URL: https://github.com/apache/drill/pull/2497
# [DRILL-8165](https://issues.apache.org/jira/browse/DRILL-8165): Upgrade liquibase because of CVE-2022-0839
## Description
Split from the #2493
Please note that we should replace the `DatabaseFactory.getInstance()` with `Scope.getCurrentScope().getSingleton(DatabaseFactory.class)` once the following issue is resolved.
## Documentation
N/A
## Testing
Use the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on a change in pull request #2497: DRILL-8165: Upgrade liquibase because of CVE-2022-0839
Posted by GitBox <gi...@apache.org>.
cgivre commented on a change in pull request #2497:
URL: https://github.com/apache/drill/pull/2497#discussion_r829955636
##########
File path: metastore/rdbms-metastore/src/main/java/org/apache/drill/metastore/rdbms/RdbmsMetastore.java
##########
@@ -117,6 +117,8 @@ private HikariDataSource dataSource(DrillConfig config) {
private void initTables(DataSource dataSource) {
try (Connection connection = dataSource.getConnection()) {
JdbcConnection jdbcConnection = new JdbcConnection(connection);
+ // TODO It is recommended to use the new function if the following issue is resolved.
+ // https://github.com/liquibase/liquibase/issues/2349
Review comment:
@luocooong Thanks for this. Would you mind creating a JIRA issue for this and listing it in the comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] luocooong commented on a change in pull request #2497: DRILL-8165: Upgrade liquibase because of CVE-2022-0839
Posted by GitBox <gi...@apache.org>.
luocooong commented on a change in pull request #2497:
URL: https://github.com/apache/drill/pull/2497#discussion_r830056707
##########
File path: metastore/rdbms-metastore/src/main/java/org/apache/drill/metastore/rdbms/RdbmsMetastore.java
##########
@@ -117,6 +117,8 @@ private HikariDataSource dataSource(DrillConfig config) {
private void initTables(DataSource dataSource) {
try (Connection connection = dataSource.getConnection()) {
JdbcConnection jdbcConnection = new JdbcConnection(connection);
+ // TODO It is recommended to use the new function if the following issue is resolved.
+ // https://github.com/liquibase/liquibase/issues/2349
Review comment:
Good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on a change in pull request #2497: DRILL-8165: Upgrade liquibase because of CVE-2022-0839
Posted by GitBox <gi...@apache.org>.
cgivre commented on a change in pull request #2497:
URL: https://github.com/apache/drill/pull/2497#discussion_r829955636
##########
File path: metastore/rdbms-metastore/src/main/java/org/apache/drill/metastore/rdbms/RdbmsMetastore.java
##########
@@ -117,6 +117,8 @@ private HikariDataSource dataSource(DrillConfig config) {
private void initTables(DataSource dataSource) {
try (Connection connection = dataSource.getConnection()) {
JdbcConnection jdbcConnection = new JdbcConnection(connection);
+ // TODO It is recommended to use the new function if the following issue is resolved.
+ // https://github.com/liquibase/liquibase/issues/2349
Review comment:
@luocooong Thanks for this. Would you mind creating a JIRA issue for this and listing it in the comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre merged pull request #2497: DRILL-8165: Upgrade liquibase because of CVE-2022-0839
Posted by GitBox <gi...@apache.org>.
cgivre merged pull request #2497:
URL: https://github.com/apache/drill/pull/2497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] luocooong commented on a change in pull request #2497: DRILL-8165: Upgrade liquibase because of CVE-2022-0839
Posted by GitBox <gi...@apache.org>.
luocooong commented on a change in pull request #2497:
URL: https://github.com/apache/drill/pull/2497#discussion_r830056707
##########
File path: metastore/rdbms-metastore/src/main/java/org/apache/drill/metastore/rdbms/RdbmsMetastore.java
##########
@@ -117,6 +117,8 @@ private HikariDataSource dataSource(DrillConfig config) {
private void initTables(DataSource dataSource) {
try (Connection connection = dataSource.getConnection()) {
JdbcConnection jdbcConnection = new JdbcConnection(connection);
+ // TODO It is recommended to use the new function if the following issue is resolved.
+ // https://github.com/liquibase/liquibase/issues/2349
Review comment:
Good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org