You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2016/12/01 07:11:30 UTC

Review Request 54246: ATLAS-1346: No graph rollbacks on read-only APIs.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54246/
-----------------------------------------------------------

Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad.


Bugs: ATLAS-1346
    https://issues.apache.org/jira/browse/ATLAS-1346


Repository: atlas


Description
-------

ATLAS-1346: No graph rollbacks on read-only APIs.


Diffs
-----

  repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 816832b912130e89279cd6cd3e8c3e94c85fa6a8 

Diff: https://reviews.apache.org/r/54246/diff/


Testing
-------

Tests passing and verified no rollback messages during a NOT FOUND situation for get*DefByGuid/Name


Thanks,

Apoorv Naik


Re: Review Request 54246: ATLAS-1349: Reduce excessive exception logging

Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54246/#review157724
-----------------------------------------------------------


Ship it!




Ship It!

- Vimal Sharma


On Dec. 1, 2016, 7:08 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54246/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2016, 7:08 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1349
>     https://issues.apache.org/jira/browse/ATLAS-1349
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1349: Reduce excessive exception logging
> 
> 
> Diffs
> -----
> 
>   authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java 9327f637033ec6ca647c829bad7052a2bcbda232 
>   repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java c773bac217666f6f430cca4a726143cbe03205f5 
>   server-api/src/main/java/org/apache/atlas/typesystem/exception/EntityNotFoundException.java 0fec8956a8fedbf70d5c0393e1f11576bdc40001 
>   server-api/src/main/java/org/apache/atlas/typesystem/exception/NotFoundException.java PRE-CREATION 
>   server-api/src/main/java/org/apache/atlas/typesystem/exception/SchemaNotFoundException.java 3214149efe87cb6ba61965c6360892659128ffda 
>   server-api/src/main/java/org/apache/atlas/typesystem/exception/TraitNotFoundException.java 59c657c119eadcbcf343e02aea72053f11707497 
>   webapp/src/main/java/org/apache/atlas/web/errors/AtlasBaseExceptionMapper.java 70b24820559cfc13013563f20b314b364dd71f5b 
>   webapp/src/main/java/org/apache/atlas/web/errors/ExceptionMapperUtil.java a14f939274f42dab47e03a2db55fb9e0f67f2dd5 
>   webapp/src/main/java/org/apache/atlas/web/errors/NotFoundExceptionMapper.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54246/diff/
> 
> 
> Testing
> -------
> 
> Tests passing and verified no rollback/exception messages during a NOT FOUND situation.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Re: Review Request 54246: ATLAS-1349: Reduce excessive exception logging

Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54246/
-----------------------------------------------------------

(Updated Dec. 1, 2016, 7:08 p.m.)


Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad.


Summary (updated)
-----------------

ATLAS-1349: Reduce excessive exception logging


Bugs: ATLAS-1349
    https://issues.apache.org/jira/browse/ATLAS-1349


Repository: atlas


Description (updated)
-------

ATLAS-1349: Reduce excessive exception logging


Diffs (updated)
-----

  authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java 9327f637033ec6ca647c829bad7052a2bcbda232 
  repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java c773bac217666f6f430cca4a726143cbe03205f5 
  server-api/src/main/java/org/apache/atlas/typesystem/exception/EntityNotFoundException.java 0fec8956a8fedbf70d5c0393e1f11576bdc40001 
  server-api/src/main/java/org/apache/atlas/typesystem/exception/NotFoundException.java PRE-CREATION 
  server-api/src/main/java/org/apache/atlas/typesystem/exception/SchemaNotFoundException.java 3214149efe87cb6ba61965c6360892659128ffda 
  server-api/src/main/java/org/apache/atlas/typesystem/exception/TraitNotFoundException.java 59c657c119eadcbcf343e02aea72053f11707497 
  webapp/src/main/java/org/apache/atlas/web/errors/AtlasBaseExceptionMapper.java 70b24820559cfc13013563f20b314b364dd71f5b 
  webapp/src/main/java/org/apache/atlas/web/errors/ExceptionMapperUtil.java a14f939274f42dab47e03a2db55fb9e0f67f2dd5 
  webapp/src/main/java/org/apache/atlas/web/errors/NotFoundExceptionMapper.java PRE-CREATION 

Diff: https://reviews.apache.org/r/54246/diff/


Testing (updated)
-------

Tests passing and verified no rollback/exception messages during a NOT FOUND situation.


Thanks,

Apoorv Naik