[GitHub] [spark] peter-toth commented on a change in pull request #27453: [SPARK-24914][SQL] Introduce new statistic to improve data size estimate for columnar storage formats (part 1)

[GitBox <gi...@apache.org>]

peter-toth commented on a change in pull request #27453: [SPARK-24914][SQL] Introduce new statistic to improve data size estimate for columnar storage formats (part 1)
URL: https://github.com/apache/spark/pull/27453#discussion_r376436911
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionTestBase.scala
 ##########
 @@ -374,4 +376,14 @@ abstract class StatisticsCollectionTestBase extends QueryTest with SQLTestUtils
       assert(relation.stats.attributeStats.isEmpty)
     }
   }
+
+  def checkNumBroadcastHashJoins(df: DataFrame, expectedNumBhj: Int, clue: String): Unit = {
+    val plan = EnsureRequirements(spark.sessionState.conf).apply(df.queryExecution.sparkPlan)
 
 Review comment:
   You don't need `EnsureRequirements` to count the number of joins.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org