You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/03/23 13:23:45 UTC

[GitHub] [hive] veghlaci05 commented on a change in pull request #3126: HIVE-26026: Use the new "REFUSED" compaction state where it makes sense

veghlaci05 commented on a change in pull request #3126:
URL: https://github.com/apache/hive/pull/3126#discussion_r833261243



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -627,18 +608,27 @@ public CompactorMR getMrCompactor() {
     return new CompactorMR();
   }
 
-  private void markFailed(CompactionInfo ci, String errorMessage) {
-    if (ci != null && StringUtils.isNotBlank(errorMessage)) {
+  private void markErrorous(CompactionInfo ci, String errorMessage, boolean failed) {

Review comment:
       I did not split it because the code would be the same except for the markXXXX call. I created an enum instead of the boolean, so it is more readable what state will be set.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org