[GitHub] [pulsar] devinbost commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage

[GitBox <gi...@apache.org>]

devinbost commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage
URL: https://github.com/apache/pulsar/pull/6031#discussion_r367027547
 
 

 ##########
 File path: pulsar-function-go/pf/instance.go
 ##########
 @@ -21,12 +21,13 @@ package pf
 
 import (
 	"context"
+	"github.com/golang/protobuf/ptypes/empty"
 	"math"
 	"time"
 
 	"github.com/apache/pulsar/pulsar-client-go/pulsar"
 	log "github.com/apache/pulsar/pulsar-function-go/logutil"
-	"github.com/apache/pulsar/pulsar-function-go/pb"
+	pb "github.com/apache/pulsar/pulsar-function-go/pb"
 
 Review comment:
   When I make this change, I can't get it to build. I get unresolved variables, even if I remove pb from the references in the code. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services