You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/26 12:57:35 UTC
[GitHub] [spark] Ngone51 opened a new pull request #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Ngone51 opened a new pull request #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Remove `executorsPendingToRemove.clear()` in `CoarseGrainedSchedulerBackend.reset()`
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Clear `executorsPendingToRemove` in `CoarseGrainedSchedulerBackend.reset()` will cause all tasks running on those "pending to remove" executors to count failures. But that's not true for the case of `executorsPendingToRemove(execId)=true`.
Besides, `executorsPendingToRemove` will be cleaned up within `removeExecutor()` at the end.
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added a new test in `TaskSetManagerSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569055455
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570540744
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569383687
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115877/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#discussion_r362463687
##########
File path: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
##########
@@ -1894,4 +1903,59 @@ class TaskSetManagerSuite extends SparkFunSuite with LocalSparkContext with Logg
manager.handleFailedTask(offerResult.get.taskId, TaskState.FAILED, reason)
assert(sched.taskSetsFailed.contains(taskSet.id))
}
+
+ test("SPARK-30359: don't clean executorsPendingToRemove " +
+ "at the beginning of CoarseGrainedSchedulerBackend.reset") {
+ val conf = new SparkConf()
+ // use local-cluster mode in order to get CoarseGrainedSchedulerBackend
+ .setMaster("local-cluster[2, 1, 2048]")
+ // allow to set up at most two executors
+ .set("spark.cores.max", "2")
+ .setAppName("CoarseGrainedSchedulerBackend.reset")
+ sc = new SparkContext(conf)
+ val sched = sc.taskScheduler
+ val backend = sc.schedulerBackend.asInstanceOf[CoarseGrainedSchedulerBackend]
+
+ TestUtils.waitUntilExecutorsUp(sc, 2, 60000)
+ val Seq(exec0, exec1) = backend.getExecutorIds()
+
+ val taskSet = FakeTask.createTaskSet(2)
+ val stageId = taskSet.stageId
+ val stageAttemptId = taskSet.stageAttemptId
+ sched.submitTasks(taskSet)
+ val taskSetManagers = PrivateMethod[mutable.HashMap[Int, mutable.HashMap[Int, TaskSetManager]]](
+ Symbol("taskSetsByStageIdAndAttempt"))
+ // get the TaskSetManager
+ val manager = sched.invokePrivate(taskSetManagers()).get(stageId).get(stageAttemptId)
+
+ val task0 = manager.resourceOffer(exec0, "localhost", TaskLocality.NO_PREF)
+ val task1 = manager.resourceOffer(exec1, "localhost", TaskLocality.NO_PREF)
+ assert(task0.isDefined && task1.isDefined)
+ val (taskId0, index0) = (task0.get.taskId, task0.get.index)
+ val (taskId1, index1) = (task1.get.taskId, task1.get.index)
+ // set up two running tasks
+ assert(manager.taskInfos(taskId0).running)
+ assert(manager.taskInfos(taskId0).executorId === exec0)
+ assert(manager.taskInfos(taskId1).running)
+ assert(manager.taskInfos(taskId1).executorId === exec1)
+
+ val numFailures = PrivateMethod[Array[Int]](Symbol("numFailures"))
+ // no task failures yet
+ assert(manager.invokePrivate(numFailures())(index0) === 0)
+ assert(manager.invokePrivate(numFailures())(index1) === 0)
+
+ // task0 on exec0 should not count failures
+ backend.executorsPendingToRemove(exec0) = true
+ // task1 on exec1 should count failures
Review comment:
Here, `executorsPendingToRemove(exec0)=true` while `executorsPendingToRemove(exec1)=false`. And `false` means that the crash of executor may possibly related to bad tasks running on it. So, those task should be counted failures. However, `true` means the executor is killed by driver and has non business of tasks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569195529
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569198758
**[Test build #115842 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115842/testReport)** for PR 27017 at commit [`eae69ce`](https://github.com/apache/spark/commit/eae69ce5a5d6f7ccd3d87d4f9379cae8d081518c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27017: [SPARK-30359][CORE]
Don't clear executorsPendingToRemove at the beginning of
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570496430
**[Test build #116080 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/116080/testReport)** for PR 27017 at commit [`4fdb7cb`](https://github.com/apache/spark/commit/4fdb7cb15b8e285919b26e97eba4ad65c5d970e0).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569382206
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115876/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569199005
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569068549
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20608/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570494434
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20872/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on issue #27017: [SPARK-30359][CORE] Do
not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569076385
cc @cloud-fan @jiangxb1987 @jerryshao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569090495
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115816/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569068546
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27017: [SPARK-30359][CORE]
Don't clear executorsPendingToRemove at the beginning of
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570494130
**[Test build #116080 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/116080/testReport)** for PR 27017 at commit [`4fdb7cb`](https://github.com/apache/spark/commit/4fdb7cb15b8e285919b26e97eba4ad65c5d970e0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569068549
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20608/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569375819
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20670/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569055455
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27017: [SPARK-30359][CORE] Do
not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569090061
**[Test build #115816 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115816/testReport)** for PR 27017 at commit [`3cfd80f`](https://github.com/apache/spark/commit/3cfd80f74a29af502c780e8e593dbb66ce10115e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Move executorsPendingToRemove.clear to the end of
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Move executorsPendingToRemove.clear to the end of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569195532
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115837/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570496455
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569180337
**[Test build #115837 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115837/testReport)** for PR 27017 at commit [`3368a3e`](https://github.com/apache/spark/commit/3368a3e35e68370dc2449c5c5a879a01147b84c8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569055249
**[Test build #115812 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115812/testReport)** for PR 27017 at commit [`511058c`](https://github.com/apache/spark/commit/511058c4c3e6baf3491311ee829b5340df51a4b5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569216509
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115842/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27017: [SPARK-30359][CORE] Do
not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569195417
**[Test build #115837 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115837/testReport)** for PR 27017 at commit [`3368a3e`](https://github.com/apache/spark/commit/3368a3e35e68370dc2449c5c5a879a01147b84c8).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#discussion_r361769421
##########
File path: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
##########
@@ -1894,4 +1903,60 @@ class TaskSetManagerSuite extends SparkFunSuite with LocalSparkContext with Logg
manager.handleFailedTask(offerResult.get.taskId, TaskState.FAILED, reason)
assert(sched.taskSetsFailed.contains(taskSet.id))
}
+
+ test("SPARK-30359: Don't clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset")
+ {
+ val conf = new SparkConf()
+ // use local-cluster mode in order to get CoarseGrainedSchedulerBackend
+ .setMaster("local-cluster[2, 1, 2048]")
+ // allow to set up at most two executors
+ .set("spark.cores.max", "2")
Review comment:
In order to create at most 2 executors at the beginning...Though, this may not necessary..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27017: [SPARK-30359][CORE]
Don't clear executorsPendingToRemove at the beginning of
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570594335
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#discussion_r361592575
##########
File path: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
##########
@@ -1894,4 +1903,60 @@ class TaskSetManagerSuite extends SparkFunSuite with LocalSparkContext with Logg
manager.handleFailedTask(offerResult.get.taskId, TaskState.FAILED, reason)
assert(sched.taskSetsFailed.contains(taskSet.id))
}
+
+ test("SPARK-30359: Don't clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset")
Review comment:
nit: `don't clean executorsPendingToRemove at the beginning of 'reset'`. We do clear it at the end.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569374481
**[Test build #115877 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115877/testReport)** for PR 27017 at commit [`d12dd45`](https://github.com/apache/spark/commit/d12dd455a0d3107e341eeb99d718d4cbec6ba5dc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570540748
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116084/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569199011
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20635/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569195529
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jiangxb1987 commented on issue #27017: [SPARK-30359][CORE]
Don't clear executorsPendingToRemove at the beginning of
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
jiangxb1987 commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569373858
Jenkins retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27017: [SPARK-30359][CORE] Do
not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569068360
**[Test build #115816 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115816/testReport)** for PR 27017 at commit [`3cfd80f`](https://github.com/apache/spark/commit/3cfd80f74a29af502c780e8e593dbb66ce10115e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27017: [SPARK-30359][CORE]
Don't clear executorsPendingToRemove at the beginning of
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569373851
**[Test build #115876 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115876/testReport)** for PR 27017 at commit [`d12dd45`](https://github.com/apache/spark/commit/d12dd455a0d3107e341eeb99d718d4cbec6ba5dc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569384695
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115879/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569384694
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27017: [SPARK-30359][CORE]
Don't clear executorsPendingToRemove at the beginning of
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569383597
**[Test build #115877 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115877/testReport)** for PR 27017 at commit [`d12dd45`](https://github.com/apache/spark/commit/d12dd455a0d3107e341eeb99d718d4cbec6ba5dc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570496461
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116080/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569383683
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569056459
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569090485
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jiangxb1987 commented on a change in pull request #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
jiangxb1987 commented on a change in pull request #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#discussion_r361769286
##########
File path: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
##########
@@ -1904,8 +1904,7 @@ class TaskSetManagerSuite
assert(sched.taskSetsFailed.contains(taskSet.id))
}
- test("SPARK-30359: Don't clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset")
- {
+ test("SPARK-30359: don't clean executorsPendingToRemove at the beginning of 'reset'") {
Review comment:
nit: you still need to mention `CoarseGrainedSchedulerBackend.reset`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569055458
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20604/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569216504
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569375819
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20670/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570494429
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569180506
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20630/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570497888
**[Test build #116084 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/116084/testReport)** for PR 27017 at commit [`4fdb7cb`](https://github.com/apache/spark/commit/4fdb7cb15b8e285919b26e97eba4ad65c5d970e0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27017: [SPARK-30359][CORE] Do
not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569180337
**[Test build #115837 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115837/testReport)** for PR 27017 at commit [`3368a3e`](https://github.com/apache/spark/commit/3368a3e35e68370dc2449c5c5a879a01147b84c8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569216504
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27017: [SPARK-30359][CORE]
Don't clear executorsPendingToRemove at the beginning of
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570496884
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27017: [SPARK-30359][CORE]
Don't clear executorsPendingToRemove at the beginning of
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570497888
**[Test build #116084 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/116084/testReport)** for PR 27017 at commit [`4fdb7cb`](https://github.com/apache/spark/commit/4fdb7cb15b8e285919b26e97eba4ad65c5d970e0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569382206
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115876/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569375679
**[Test build #115879 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115879/testReport)** for PR 27017 at commit [`77c09e8`](https://github.com/apache/spark/commit/77c09e8db7e8846659a61ee984d46dc9994d5e99).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569055458
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20604/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570498249
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #27017: [SPARK-30359][CORE]
Don't clear executorsPendingToRemove at the beginning of
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jiangxb1987 commented on a change in pull request #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
jiangxb1987 commented on a change in pull request #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#discussion_r361769076
##########
File path: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
##########
@@ -1894,4 +1903,60 @@ class TaskSetManagerSuite extends SparkFunSuite with LocalSparkContext with Logg
manager.handleFailedTask(offerResult.get.taskId, TaskState.FAILED, reason)
assert(sched.taskSetsFailed.contains(taskSet.id))
}
+
+ test("SPARK-30359: Don't clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset")
+ {
+ val conf = new SparkConf()
+ // use local-cluster mode in order to get CoarseGrainedSchedulerBackend
+ .setMaster("local-cluster[2, 1, 2048]")
+ // allow to set up at most two executors
+ .set("spark.cores.max", "2")
+ .setAppName("CoarseGrainedSchedulerBackend.reset")
+ sc = new SparkContext(conf)
+ val sched = sc.taskScheduler
+ val backend = sc.schedulerBackend.asInstanceOf[CoarseGrainedSchedulerBackend]
+
+ TestUtils.waitUntilExecutorsUp(sc, 2, 60000)
+ val Seq(exec0, exec1) = backend.getExecutorIds()
+
+ val taskSet = FakeTask.createTaskSet(2)
+ val stageId = taskSet.stageId
+ val stageAttemptId = taskSet.stageAttemptId
+ sched.submitTasks(taskSet)
+ val taskSetManagers = PrivateMethod[mutable.HashMap[Int, mutable.HashMap[Int, TaskSetManager]]](
+ Symbol("taskSetsByStageIdAndAttempt"))
+ // get the TaskSetManager
+ val manager = sched.invokePrivate(taskSetManagers()).get(stageId).get(stageAttemptId)
+
+ val task0 = manager.resourceOffer(exec0, "localhost", TaskLocality.NO_PREF)
+ val task1 = manager.resourceOffer(exec1, "localhost", TaskLocality.NO_PREF)
+ assert(task0.isDefined && task1.isDefined)
+ val (taskId0, index0) = (task0.get.taskId, task0.get.index)
+ val (taskId1, index1) = (task1.get.taskId, task1.get.index)
+ // set up two running tasks
+ assert(manager.taskInfos(taskId0).running)
+ assert(manager.taskInfos(taskId0).executorId === exec0)
+ assert(manager.taskInfos(taskId1).running)
+ assert(manager.taskInfos(taskId1).executorId === exec1)
+
+ val numFailures = PrivateMethod[Array[Int]](Symbol("numFailures"))
+ // no task failures yet
+ assert(manager.invokePrivate(numFailures())(index0) === 0)
+ assert(manager.invokePrivate(numFailures())(index1) === 0)
+
+ // task0 on exec0 should not count failures
+ backend.executorsPendingToRemove(exec0) = true
+ // task1 on exec1 should count failures
+ backend.executorsPendingToRemove(exec1) = false
+
+ backend.reset()
+
+ eventually(timeout(10.seconds), interval(100.milliseconds)) {
+ // executorsPendingToRemove should still be empty after reset()
Review comment:
nit: `stil` -> `eventually`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570540744
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570494429
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#discussion_r362440210
##########
File path: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
##########
@@ -1894,4 +1903,59 @@ class TaskSetManagerSuite extends SparkFunSuite with LocalSparkContext with Logg
manager.handleFailedTask(offerResult.get.taskId, TaskState.FAILED, reason)
assert(sched.taskSetsFailed.contains(taskSet.id))
}
+
+ test("SPARK-30359: don't clean executorsPendingToRemove " +
+ "at the beginning of CoarseGrainedSchedulerBackend.reset") {
+ val conf = new SparkConf()
+ // use local-cluster mode in order to get CoarseGrainedSchedulerBackend
+ .setMaster("local-cluster[2, 1, 2048]")
+ // allow to set up at most two executors
+ .set("spark.cores.max", "2")
+ .setAppName("CoarseGrainedSchedulerBackend.reset")
+ sc = new SparkContext(conf)
+ val sched = sc.taskScheduler
+ val backend = sc.schedulerBackend.asInstanceOf[CoarseGrainedSchedulerBackend]
+
+ TestUtils.waitUntilExecutorsUp(sc, 2, 60000)
+ val Seq(exec0, exec1) = backend.getExecutorIds()
+
+ val taskSet = FakeTask.createTaskSet(2)
+ val stageId = taskSet.stageId
+ val stageAttemptId = taskSet.stageAttemptId
+ sched.submitTasks(taskSet)
+ val taskSetManagers = PrivateMethod[mutable.HashMap[Int, mutable.HashMap[Int, TaskSetManager]]](
+ Symbol("taskSetsByStageIdAndAttempt"))
+ // get the TaskSetManager
+ val manager = sched.invokePrivate(taskSetManagers()).get(stageId).get(stageAttemptId)
+
+ val task0 = manager.resourceOffer(exec0, "localhost", TaskLocality.NO_PREF)
+ val task1 = manager.resourceOffer(exec1, "localhost", TaskLocality.NO_PREF)
+ assert(task0.isDefined && task1.isDefined)
+ val (taskId0, index0) = (task0.get.taskId, task0.get.index)
+ val (taskId1, index1) = (task1.get.taskId, task1.get.index)
+ // set up two running tasks
+ assert(manager.taskInfos(taskId0).running)
+ assert(manager.taskInfos(taskId0).executorId === exec0)
+ assert(manager.taskInfos(taskId1).running)
+ assert(manager.taskInfos(taskId1).executorId === exec1)
+
+ val numFailures = PrivateMethod[Array[Int]](Symbol("numFailures"))
+ // no task failures yet
+ assert(manager.invokePrivate(numFailures())(index0) === 0)
+ assert(manager.invokePrivate(numFailures())(index1) === 0)
+
+ // task0 on exec0 should not count failures
+ backend.executorsPendingToRemove(exec0) = true
+ // task1 on exec1 should count failures
Review comment:
what makes exec1 different from exec0 and count failures?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569373979
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20668/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#discussion_r361590036
##########
File path: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
##########
@@ -506,6 +506,7 @@ class CoarseGrainedSchedulerBackend(scheduler: TaskSchedulerImpl, val rpcEnv: Rp
executors.foreach { eid =>
removeExecutor(eid, SlaveLost("Stale executor after cluster manager re-registered."))
}
+ synchronized { executorsPendingToRemove.clear() }
Review comment:
`removeExecutor()` is asynchronous, so clear `executorsPendingToRemove` at the end of `reset()` can not work. We should revert this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569056462
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115812/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569180499
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570496461
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116080/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570494434
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20872/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569199011
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20635/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569199005
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569373851
**[Test build #115876 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115876/testReport)** for PR 27017 at commit [`d12dd45`](https://github.com/apache/spark/commit/d12dd455a0d3107e341eeb99d718d4cbec6ba5dc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jiangxb1987 commented on a change in pull request #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
jiangxb1987 commented on a change in pull request #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#discussion_r361768905
##########
File path: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
##########
@@ -1894,4 +1903,60 @@ class TaskSetManagerSuite extends SparkFunSuite with LocalSparkContext with Logg
manager.handleFailedTask(offerResult.get.taskId, TaskState.FAILED, reason)
assert(sched.taskSetsFailed.contains(taskSet.id))
}
+
+ test("SPARK-30359: Don't clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset")
+ {
+ val conf = new SparkConf()
+ // use local-cluster mode in order to get CoarseGrainedSchedulerBackend
+ .setMaster("local-cluster[2, 1, 2048]")
+ // allow to set up at most two executors
+ .set("spark.cores.max", "2")
Review comment:
why do we still need this config?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569375817
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569090485
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27017: [SPARK-30359][CORE] Do
not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569198758
**[Test build #115842 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115842/testReport)** for PR 27017 at commit [`eae69ce`](https://github.com/apache/spark/commit/eae69ce5a5d6f7ccd3d87d4f9379cae8d081518c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570498256
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20876/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569056462
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115812/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jiangxb1987 commented on a change in pull request #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
jiangxb1987 commented on a change in pull request #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#discussion_r361769178
##########
File path: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
##########
@@ -1894,4 +1903,60 @@ class TaskSetManagerSuite extends SparkFunSuite with LocalSparkContext with Logg
manager.handleFailedTask(offerResult.get.taskId, TaskState.FAILED, reason)
assert(sched.taskSetsFailed.contains(taskSet.id))
}
+
+ test("SPARK-30359: Don't clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset")
+ {
+ val conf = new SparkConf()
+ // use local-cluster mode in order to get CoarseGrainedSchedulerBackend
+ .setMaster("local-cluster[2, 1, 2048]")
+ // allow to set up at most two executors
+ .set("spark.cores.max", "2")
+ .setAppName("CoarseGrainedSchedulerBackend.reset")
+ sc = new SparkContext(conf)
+ val sched = sc.taskScheduler
+ val backend = sc.schedulerBackend.asInstanceOf[CoarseGrainedSchedulerBackend]
+
+ TestUtils.waitUntilExecutorsUp(sc, 2, 60000)
+ val Seq(exec0, exec1) = backend.getExecutorIds()
+
+ val taskSet = FakeTask.createTaskSet(2)
+ val stageId = taskSet.stageId
+ val stageAttemptId = taskSet.stageAttemptId
+ sched.submitTasks(taskSet)
+ val taskSetManagers = PrivateMethod[mutable.HashMap[Int, mutable.HashMap[Int, TaskSetManager]]](
+ Symbol("taskSetsByStageIdAndAttempt"))
+ // get the TaskSetManager
+ val manager = sched.invokePrivate(taskSetManagers()).get(stageId).get(stageAttemptId)
+
+ val task0 = manager.resourceOffer(exec0, "localhost", TaskLocality.NO_PREF)
+ val task1 = manager.resourceOffer(exec1, "localhost", TaskLocality.NO_PREF)
+ assert(task0.isDefined && task1.isDefined)
+ val (taskId0, index0) = (task0.get.taskId, task0.get.index)
+ val (taskId1, index1) = (task1.get.taskId, task1.get.index)
+ // set up two running tasks
+ assert(manager.taskInfos(taskId0).running)
+ assert(manager.taskInfos(taskId0).executorId === exec0)
+ assert(manager.taskInfos(taskId1).running)
+ assert(manager.taskInfos(taskId1).executorId === exec1)
+
+ val numFailures = PrivateMethod[Array[Int]](Symbol("numFailures"))
+ // no task failures yet
+ assert(manager.invokePrivate(numFailures())(index0) === 0)
+ assert(manager.invokePrivate(numFailures())(index1) === 0)
+
+ // task0 on exec0 should not count failures
+ backend.executorsPendingToRemove(exec0) = true
+ // task1 on exec1 should count failures
+ backend.executorsPendingToRemove(exec1) = false
+
+ backend.reset()
+
+ eventually(timeout(10.seconds), interval(100.milliseconds)) {
+ // executorsPendingToRemove should still be empty after reset()
+ assert(backend.executorsPendingToRemove.isEmpty)
+ assert(manager.invokePrivate(numFailures())(index0) === 0)
+ assert(manager.invokePrivate(numFailures())(index1) === 1)
+ }
+ sc.stop()
Review comment:
This is not necessary coz `LocalSparkContext` would stop it after each test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569382204
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27017: [SPARK-30359][CORE]
Don't clear executorsPendingToRemove at the beginning of
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569374481
**[Test build #115877 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115877/testReport)** for PR 27017 at commit [`d12dd45`](https://github.com/apache/spark/commit/d12dd455a0d3107e341eeb99d718d4cbec6ba5dc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27017: [SPARK-30359][CORE]
Don't clear executorsPendingToRemove at the beginning of
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569384580
**[Test build #115879 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115879/testReport)** for PR 27017 at commit [`77c09e8`](https://github.com/apache/spark/commit/77c09e8db7e8846659a61ee984d46dc9994d5e99).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570540748
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116084/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27017: [SPARK-30359][CORE]
Don't clear executorsPendingToRemove at the beginning of
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569375679
**[Test build #115879 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115879/testReport)** for PR 27017 at commit [`77c09e8`](https://github.com/apache/spark/commit/77c09e8db7e8846659a61ee984d46dc9994d5e99).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569216509
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115842/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27017: [SPARK-30359][CORE]
Don't clear executorsPendingToRemove at the beginning of
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570540019
**[Test build #116084 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/116084/testReport)** for PR 27017 at commit [`4fdb7cb`](https://github.com/apache/spark/commit/4fdb7cb15b8e285919b26e97eba4ad65c5d970e0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27017: [SPARK-30359][CORE]
Don't clear executorsPendingToRemove at the beginning of
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569382080
**[Test build #115876 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115876/testReport)** for PR 27017 at commit [`d12dd45`](https://github.com/apache/spark/commit/d12dd455a0d3107e341eeb99d718d4cbec6ba5dc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569382204
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569373977
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569180499
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569384694
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569375817
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570496455
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569384695
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115879/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569383683
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569383687
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115877/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#discussion_r361592575
##########
File path: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
##########
@@ -1894,4 +1903,60 @@ class TaskSetManagerSuite extends SparkFunSuite with LocalSparkContext with Logg
manager.handleFailedTask(offerResult.get.taskId, TaskState.FAILED, reason)
assert(sched.taskSetsFailed.contains(taskSet.id))
}
+
+ test("SPARK-30359: Don't clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset")
Review comment:
nit: `don't clean executorsPendingToRemove at the beginning of 'reset'`. We do clear it eventually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27017:
[SPARK-30359][CORE] Move executorsPendingToRemove.clear to the end of
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27017: [SPARK-30359][CORE] Move executorsPendingToRemove.clear to the end of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#discussion_r361588123
##########
File path: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
##########
@@ -506,6 +506,7 @@ class CoarseGrainedSchedulerBackend(scheduler: TaskSchedulerImpl, val rpcEnv: Rp
executors.foreach { eid =>
removeExecutor(eid, SlaveLost("Stale executor after cluster manager re-registered."))
}
+ synchronized { executorsPendingToRemove.clear() }
Review comment:
can we add some comments? usually this should be empty when we reach here, we do this in cases something goes wrong and we must make sure all the states has been reset.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570498249
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27017: [SPARK-30359][CORE] Do
not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569055249
**[Test build #115812 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115812/testReport)** for PR 27017 at commit [`511058c`](https://github.com/apache/spark/commit/511058c4c3e6baf3491311ee829b5340df51a4b5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569180506
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20630/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569373979
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20668/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27017: [SPARK-30359][CORE] Do
not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569056449
**[Test build #115812 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115812/testReport)** for PR 27017 at commit [`511058c`](https://github.com/apache/spark/commit/511058c4c3e6baf3491311ee829b5340df51a4b5).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569068360
**[Test build #115816 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115816/testReport)** for PR 27017 at commit [`3cfd80f`](https://github.com/apache/spark/commit/3cfd80f74a29af502c780e8e593dbb66ce10115e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569090495
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115816/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569195532
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115837/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27017: [SPARK-30359][CORE] Do
not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569216384
**[Test build #115842 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115842/testReport)** for PR 27017 at commit [`eae69ce`](https://github.com/apache/spark/commit/eae69ce5a5d6f7ccd3d87d4f9379cae8d081518c).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570494130
**[Test build #116080 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/116080/testReport)** for PR 27017 at commit [`4fdb7cb`](https://github.com/apache/spark/commit/4fdb7cb15b8e285919b26e97eba4ad65c5d970e0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-570498256
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20876/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569056459
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017:
[SPARK-30359][CORE] Do not clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569068546
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017:
[SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning
of CoarseGrainedSchedulerBackend.reset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#issuecomment-569373977
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org